fix(s3Stream): support aliyun oss #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Curtis Wan <[email protected]>
|
|
Signed-off-by: Curtis Wan <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #804 +/- ##
============================================
- Coverage 56.18% 56.15% -0.03%
+ Complexity 1231 1228 -3
============================================
Files 132 132
Lines 8325 8325
Branches 765 765
============================================
- Hits 4677 4675 -2
Misses 3244 3244
- Partials 404 406 +2
|
superhx
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to resolve compatibility issues when running the S3 stream on Aliyun OSS.
Currently, the AWS SDK throws an exception with the message "The request signature we calculated does not match the signature you provided." It appears that Aliyun OSS does not support paths starting with '/'. A similar issue can be referred here. Perhaps Aliyun has not fixed this particular issue.