Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename wal object to stream set object #749

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

daniel-y
Copy link
Contributor

No description provided.

@daniel-y daniel-y linked an issue Nov 28, 2023 that may be closed by this pull request
@CLAassistant
Copy link

CLAassistant commented Nov 28, 2023

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Merging #749 (7e84a6a) into main (2bac396) will not change coverage.
Report is 3 commits behind head on main.
The diff coverage is 74.80%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #749   +/-   ##
=========================================
  Coverage     57.36%   57.36%           
  Complexity     1224     1224           
=========================================
  Files           131      131           
  Lines          8047     8047           
  Branches        736      736           
=========================================
  Hits           4616     4616           
  Misses         3035     3035           
  Partials        396      396           
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 5.80% <ø> (ø)
RocketMQ Controller 54.60% <ø> (ø)
RocketMQ Proxy 42.75% <ø> (ø)
RocketMQ Store 77.00% <55.00%> (ø)
RocketMQ Stream ∅ <ø> (∅)
RocketMQ Metadata 35.44% <50.00%> (ø)
Files Coverage Δ
...utomq/rocketmq/metadata/dao/S3StreamSetObject.java 83.87% <50.00%> (ø)
...a/com/automq/rocketmq/metadata/service/Helper.java 80.00% <77.77%> (ø)
...rocketmq/metadata/DefaultStoreMetadataService.java 30.89% <50.00%> (ø)
...metadata/service/cache/S3StreamSetObjectCache.java 43.75% <50.00%> (ø)
...ava/com/automq/rocketmq/store/S3ObjectManager.java 92.30% <78.57%> (ø)
.../java/com/automq/rocketmq/store/S3StreamStore.java 0.00% <0.00%> (ø)
...tmq/metadata/service/DefaultS3MetadataService.java 67.67% <82.55%> (ø)

@daniel-y daniel-y force-pushed the 745-rename-wal-object-to-stream-set-object branch 3 times, most recently from 591d8c8 to 44ffc1b Compare November 28, 2023 09:00
@daniel-y daniel-y force-pushed the 745-rename-wal-object-to-stream-set-object branch from 44ffc1b to 7e84a6a Compare November 28, 2023 09:04
@daniel-y daniel-y enabled auto-merge (squash) November 28, 2023 09:34
@daniel-y daniel-y merged commit 48897c5 into main Nov 28, 2023
14 checks passed
@daniel-y daniel-y deleted the 745-rename-wal-object-to-stream-set-object branch November 28, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename WAL Object to Stream Set Object
3 participants