Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(s3stream): add compaction throttle to flatten load peak #595

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

SCNieh
Copy link
Contributor

@SCNieh SCNieh commented Nov 7, 2023

No description provided.

@SCNieh SCNieh requested a review from superhx November 7, 2023 07:30
@CLAassistant
Copy link

CLAassistant commented Nov 7, 2023

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #595 (1860f76) into main (d7eb6b7) will increase coverage by 0.01%.
The diff coverage is 30.76%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #595      +/-   ##
============================================
+ Coverage     58.94%   58.95%   +0.01%     
+ Complexity     1910     1908       -2     
============================================
  Files           196      196              
  Lines         12816    12838      +22     
  Branches       1220     1220              
============================================
+ Hits           7554     7569      +15     
- Misses         4652     4654       +2     
- Partials        610      615       +5     
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 12.96% <ø> (ø)
RocketMQ Controller 49.31% <ø> (ø)
RocketMQ Proxy 44.35% <ø> (-0.21%) ⬇️
RocketMQ Store 77.77% <ø> (+0.62%) ⬆️
RocketMQ Stream 60.45% <30.76%> (-0.13%) ⬇️
RocketMQ Metadata 17.64% <ø> (ø)
Files Coverage Δ
.../src/main/java/com/automq/stream/s3/S3Storage.java 60.63% <0.00%> (ø)
...m/automq/stream/s3/operator/DefaultS3Operator.java 48.64% <0.00%> (ø)
...mq/stream/s3/compact/operator/DataBlockReader.java 59.18% <69.23%> (+0.61%) ⬆️
...om/automq/stream/s3/compact/CompactionManager.java 58.14% <13.04%> (-2.27%) ⬇️

... and 3 files with indirect coverage changes

Copy link

github-actions bot commented Nov 7, 2023

Qodana for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@superhx superhx merged commit 960631c into main Nov 7, 2023
9 of 10 checks passed
@superhx superhx deleted the compaction_limit branch November 7, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants