Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Specify log4j2 configuration file using Java option log4j2.conf… #588

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

lizhanhui
Copy link
Contributor

…igurationFile such that we may have two config files, for development and release

@CLAassistant
Copy link

CLAassistant commented Nov 7, 2023

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #588 (889a97b) into main (121e70c) will decrease coverage by 0.08%.
The diff coverage is n/a.

❗ Current head 889a97b differs from pull request most recent head eb91ee6. Consider uploading reports for the commit eb91ee6 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #588      +/-   ##
============================================
- Coverage     59.07%   59.00%   -0.08%     
+ Complexity     1913     1907       -6     
============================================
  Files           196      196              
  Lines         12816    12808       -8     
  Branches       1220     1219       -1     
============================================
- Hits           7571     7557      -14     
- Misses         4635     4638       +3     
- Partials        610      613       +3     
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 12.96% <ø> (ø)
RocketMQ Controller 49.20% <ø> (ø)
RocketMQ Proxy 44.37% <ø> (-0.73%) ⬇️
RocketMQ Store 77.87% <ø> (+0.20%) ⬆️
RocketMQ Stream 60.58% <ø> (-0.04%) ⬇️
RocketMQ Metadata 17.64% <ø> (ø)

see 6 files with indirect coverage changes

Copy link

github-actions bot commented Nov 7, 2023

Qodana for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

…igurationFile such that we may have two config files, for development and release

Signed-off-by: Li Zhanhui <[email protected]>
@lizhanhui lizhanhui merged commit d7eb6b7 into main Nov 7, 2023
5 of 7 checks passed
@lizhanhui lizhanhui deleted the specify_log4j_config branch November 7, 2023 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants