Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(s3stream/wal): no need to release recovered records internally #443

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

Chillax-0v0
Copy link
Contributor

@Chillax-0v0 Chillax-0v0 added bug Something isn't working s3stream wal the WAL of S3 stream labels Oct 24, 2023
@Chillax-0v0 Chillax-0v0 self-assigned this Oct 24, 2023
@github-actions
Copy link

github-actions bot commented Oct 24, 2023

Qodana for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@Chillax-0v0 Chillax-0v0 force-pushed the fix-wal-release-twice-during-recovery branch from 6f7cd15 to 996e974 Compare October 24, 2023 08:13
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #443 (996e974) into main (4d2069b) will decrease coverage by 0.11%.
Report is 3 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #443      +/-   ##
============================================
- Coverage     57.31%   57.21%   -0.11%     
+ Complexity      815      812       -3     
============================================
  Files            99       99              
  Lines          6103     6084      -19     
  Branches        580      577       -3     
============================================
- Hits           3498     3481      -17     
+ Misses         2271     2270       -1     
+ Partials        334      333       -1     
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 12.50% <ø> (ø)
RocketMQ Controller 58.10% <ø> (-0.20%) ⬇️
RocketMQ Proxy 37.69% <ø> (ø)
RocketMQ Store 74.51% <ø> (ø)
RocketMQ Stream ∅ <ø> (∅)
RocketMQ Metadata 16.98% <ø> (-0.33%) ⬇️

see 9 files with indirect coverage changes

@superhx superhx merged commit d18cbf3 into main Oct 24, 2023
8 of 9 checks passed
@superhx superhx deleted the fix-wal-release-twice-during-recovery branch October 24, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working s3stream wal the WAL of S3 stream
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refcnt reduce to 0 on recovery
2 participants