Auto Dark Mode prevents system from going to sleep

[shadeMe]

Description
Having the Auto Dark Mode service running in the background prevents Windows from going to sleep. I've had this issue for quite some time now (system not going to sleep) but didn't manage to figure out what was causing it until just now.

Strangely enough, nothing shows up in the system logs or powercfg /requests that would indicate that that the service was the root cause.

Expected behavior
The system automatically goes to sleep as configured in the Windows power management settings.

Log Data
service.log

Commit Hash and Version

[Spiritreader]

Hello! Thank you for your report, thank you for following the bug template, and thank you for providing all the log files.
Because of this, I am immediately able to provide a fix for you.

Why the bug occurred

After every theme application, Auto Dark Mode retrieves the current theme from a windows API endpoint.
What's happening is that Windows is mis-reporting the theme you have configured even after it has been set by ADM.

For some reason, that endpoint's return value is not matching the current Windows theme, even though it was reported as applied correctly.
As such, Auto Dark Mode infinitely tries to apply your theme on every tick, which keeps Windows awake as it makes calls to an API that itself keeps your system awake. This is merely a side effect of an API issue, Auto Dark Mode does nothing directly that prevents sleep.

I am unsure what is causing this behavior and have seen it on some computers, including mine, but not to that extent (goes away on its own within minutes. Basically, the Windows API never returns the correct theme path in your case.
I'm pretty sure you did nothing to actively cause this. My suspicion is that Windows internally can't apply that theme file directly, and instead creates a Custom.theme file. That name of course wouldn't match.
(I also had this happen quite a while ago, but the API started returning the right values again at some point and the issue never re-surfaced. So I thought of it as Windows hiccup.)
This could also be connected to #192 in some way.

How to fix it

In the newer Auto Dark Mode betas, there is already an option availalbe to disable theme validation.
I have removed the validation check after ADM applies the theme in the theme handler. This means:
Disabling this option in the screenshot below in Beta build 10.0.1.51 or newer should fix this for you.
The mentioned version should be available to you within 5 minutes of this post.

[shadeMe]

Thanks very much for the quick response! The new beta build appears to have fixed the sleep issue but also seems to have introduced a regression - Automatic theme switching doesn't seem to work any more. Nor does it work when I force the theme from the system tray.

Log: service.log

[Spiritreader]

Hmm I am unable to reproduce this.
Can you attach your config file again?

[shadeMe]

config.yaml.txt

[Spiritreader]

Please try again with Beta 0.1.52.
I've done multiple changes to make the theme switching logic less strict with when it is allowed to switch.

If it still doesn't work, please open the config file, enable the Debug flag under the Tunable section, delete the service.log file, restart the service and post the entire output after attempting to switch themes automatically and manually.

[shadeMe]

That seems to have done the trick! Thanks again for the lightning-fast turn-around on this issue :) I'll keep an eye out for any other bugs.

PS: I hope that the Paypal link displayed in-app sends the proceeds to both developers (I didn't want to set up a GitHub Sponsers account).

[Spiritreader]

That seems to have done the trick! Thanks again for the lightning-fast turn-around on this issue :) I'll keep an eye out for any other bugs.

PS: I hope that the Paypal link displayed in-app sends the proceeds to both developers (I didn't want to set up a GitHub Sponsers account).

Awesome! Glad it works now!
Yes it indeed is. We share incoming donations!
Thank you very much!