Odyssey: Canon propellant depot scenarios #20264
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Greenjoe12345
requested review from
NonQueueingMatt and
DreamySkrell
as code owners
|
!review |
github-actions
bot
added
the
🗺️ Mapping - Away Ship/Away Site
hazelrat
reviewed
Dec 17, 2024
There was a problem hiding this comment.
I'm skeptical of this. Canon odysseys haven't really been explored on-server yet, but I see them consisting largely either of resorts for the crew to visit, or settlements/stations in crisis for them to resupply, repair, and save with diverse crew involvement. I don't think the propellant depot fulfils either of those roles very well. I'd say to wait until canon odysseys get merged proper rather than repurposing this one, #20261 and #20211 are both currently in the works.
DreamySkrell
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply adds the ability for the propellant depot odyssey to be able to have a canon scenario, alongside keeping it able to have a non-canon one.