Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use micromatch #1

Merged
merged 2 commits into from
Mar 1, 2022
Merged

Use micromatch #1

merged 2 commits into from
Mar 1, 2022

Conversation

Obi-Dann
Copy link
Collaborator

@Obi-Dann Obi-Dann commented Mar 1, 2022

Using micromatch instead of picomatch to be able to reduce filter like in the same way as .gitignore, eg

   # all .ts files but not tests
    src:
      - 'src/**/*.ts'
      - '!src/**/*.test.ts'

@Obi-Dann
Replace picomatch with micromatch
6706fee 
Using micromatch, removed `added|modified` rule to simplify the rules. The idea is to extend the output with things like `anyModified` or `anyDeleted` instead of putting that into the matcher rules to keep the matcher rules in sync with `micromatch` rules
@Obi-Dann
Add tests for the filter with negation
5af776f
@Obi-Dann Obi-Dann merged commit fa09eba into master Mar 1, 2022
@Obi-Dann Obi-Dann deleted the use-micromatch branch March 1, 2022 02:43
Obi-Dann pushed a commit that referenced this pull request May 2, 2023
Merge pull request #1 from jbarmash/jbarmash-upgrade-action-to-node16
f12b3ce 
Update Action to Node 16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Obi-Dann