Skip to content

fix(cli): regenerate compose and re-exec binary on update #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Aureliolo merged 10 commits into from
Mar 19, 2026
Merged

fix(cli): regenerate compose and re-exec binary on update #576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3b71c44
fix(cli): regenerate compose and re-exec binary on update
Aureliolo Mar 19, 2026
a7dfb15
fix(cli): address review findings -- secret redaction, error handling…
Aureliolo Mar 19, 2026
2e91652
fix(cli): address external + local review findings (round 2)
Aureliolo Mar 19, 2026
2fda6d9
fix(cli): preserve child exit code on re-exec, restore test perms early
Aureliolo Mar 19, 2026
ab7ac48
fix(cli): preserve compose on declined refresh, patch image refs only
Aureliolo Mar 19, 2026
4a99af0
fix(cli): validate patch replacements, fix prompt text, harden test
Aureliolo Mar 19, 2026
e487997
fix(cli): validate sandbox image ref in preserve-compose patch mode
Aureliolo Mar 19, 2026
77ca4ec
test(cli): add trailing newline removed case to TestLineDiff
Aureliolo Mar 19, 2026
52e8c05
chore: remove accidentally committed log extracts
Aureliolo Mar 19, 2026
310c564
test(cli): add redactSecret edge-case coverage
Aureliolo Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions cli/cmd/start.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ import (
"github.com/Aureliolo/synthorg/cli/internal/health"
"github.com/Aureliolo/synthorg/cli/internal/ui"
"github.com/Aureliolo/synthorg/cli/internal/verify"
"github.com/Aureliolo/synthorg/cli/internal/version"
"github.com/spf13/cobra"
)

Expand Down Expand Up @@ -43,8 +42,11 @@ func runStart(cmd *cobra.Command, args []string) error {
return err
}
composePath := filepath.Join(safeDir, "compose.yml")
if _, err := os.Stat(composePath); errors.Is(err, os.ErrNotExist) {
return fmt.Errorf("compose.yml not found in %s — run 'synthorg init' first", safeDir)
if _, err := os.Stat(composePath); err != nil {
Comment thread Dismissed
if errors.Is(err, os.ErrNotExist) {
return fmt.Errorf("compose.yml not found in %s -- run 'synthorg init' first", safeDir)
}
return fmt.Errorf("checking compose.yml: %w", err)
}

out := ui.NewUI(cmd.OutOrStdout())
Expand Down Expand Up @@ -121,7 +123,7 @@ func verifyAndPinImages(ctx context.Context, cmd *cobra.Command, state config.St
return fmt.Errorf("digest pin map: %w", err)
}

if err := writeDigestPinnedCompose(state, pins, safeDir, version.Version); err != nil {
if err := writeDigestPinnedCompose(state, pins, safeDir); err != nil {
return fmt.Errorf("pinning verified digests: %w", err)
}

Expand All @@ -137,9 +139,8 @@ func verifyAndPinImages(ctx context.Context, cmd *cobra.Command, state config.St
//
// Uses atomic write (temp file + rename) to prevent a partial write from
// corrupting the compose file if the process is interrupted.
func writeDigestPinnedCompose(state config.State, digestPins map[string]string, safeDir, cliVersion string) error {
func writeDigestPinnedCompose(state config.State, digestPins map[string]string, safeDir string) error {
params := compose.ParamsFromState(state)
params.CLIVersion = cliVersion
params.DigestPins = digestPins

composeYAML, err := compose.Generate(params)
Expand Down
Loading
Loading