fix(cli): completion cleanup on uninstall + init backend selection

cli/cmd/config.go

@@ -68,6 +68,8 @@ func runConfigShow(cmd *cobra.Command, _ []string) error {
 	if state.Sandbox && state.DockerSock != "" {
 		out.KeyValue("Docker socket", state.DockerSock)
 	}
+	out.KeyValue("Persistence backend", state.PersistenceBackend)
+	out.KeyValue("Memory backend", state.MemoryBackend)
 	out.KeyValue("JWT secret", maskSecret(state.JWTSecret))
 
 	return nil

cli/cmd/config_test.go

@@ -46,14 +46,16 @@ func TestConfigShowNotInitialized(t *testing.T) {
 func TestConfigShowDisplaysFields(t *testing.T) {
 	dir := t.TempDir()
 	state := config.State{
-		DataDir:     dir,
-		ImageTag:    "v1.2.3",
-		BackendPort: 9000,
-		WebPort:     4000,
-		Sandbox:     true,
-		DockerSock:  "/var/run/docker.sock",
-		LogLevel:    "debug",
-		JWTSecret:   "super-secret",
+		DataDir:            dir,
+		ImageTag:           "v1.2.3",
+		BackendPort:        9000,
+		WebPort:            4000,
+		Sandbox:            true,
+		DockerSock:         "/var/run/docker.sock",
+		LogLevel:           "debug",
+		JWTSecret:          "super-secret",
+		PersistenceBackend: "sqlite",
+		MemoryBackend:      "mem0",
 	}
 
 	data, err := json.MarshalIndent(state, "", "  ")
@@ -81,6 +83,8 @@ func TestConfigShowDisplaysFields(t *testing.T) {
 		"debug",
 		"/var/run/docker.sock",
 		"****",
+		"sqlite",
+		"mem0",
 	} {
 		if !bytes.Contains([]byte(out), []byte(want)) {
 			t.Errorf("expected %q in output, got: %s", want, out)

cli/cmd/init.go

@@ -81,25 +81,29 @@ func runInit(cmd *cobra.Command, _ []string) error {
 
 // setupAnswers holds raw form input before validation.
 type setupAnswers struct {
-	dir            string
-	backendPortStr string
-	webPortStr     string
-	sandbox        bool
-	dockerSock     string
-	logLevel       string
-	genJWT         bool
+	dir                string
+	backendPortStr     string
+	webPortStr         string
+	sandbox            bool
+	dockerSock         string
+	logLevel           string
+	genJWT             bool
+	persistenceBackend string
+	memoryBackend      string
 }
 
 func runSetupForm() (setupAnswers, error) {
 	defaults := config.DefaultState()
 	a := setupAnswers{
-		dir:            defaults.DataDir,
-		backendPortStr: fmt.Sprintf("%d", defaults.BackendPort),
-		webPortStr:     fmt.Sprintf("%d", defaults.WebPort),
-		sandbox:        defaults.Sandbox,
-		dockerSock:     defaultDockerSock(),
-		logLevel:       defaults.LogLevel,
-		genJWT:         true,
+		dir:                defaults.DataDir,
+		backendPortStr:     fmt.Sprintf("%d", defaults.BackendPort),
+		webPortStr:         fmt.Sprintf("%d", defaults.WebPort),
+		sandbox:            defaults.Sandbox,
+		dockerSock:         defaultDockerSock(),
+		logLevel:           defaults.LogLevel,
+		genJWT:             true,
+		persistenceBackend: defaults.PersistenceBackend,
+		memoryBackend:      defaults.MemoryBackend,
 	}
 
 	form := huh.NewForm(
@@ -126,6 +130,13 @@ func runSetupForm() (setupAnswers, error) {
 			huh.NewConfirm().Title("Generate JWT secret?").
 				Description("Recommended for API authentication").Value(&a.genJWT),
 		),
+		huh.NewGroup(
+			huh.NewNote().Title("Backends").
+				Description(fmt.Sprintf(
+					"Persistence: %s · Memory: %s\n(More options coming soon)",
+					a.persistenceBackend, a.memoryBackend,
+				)),
+		),
 	)
 
 	if err := form.Run(); err != nil {
@@ -173,14 +184,16 @@ func buildState(a setupAnswers) (config.State, error) {
 	}
 
 	return config.State{
-		DataDir:     dir,
-		ImageTag:    imageTag,
-		BackendPort: backendPort,
-		WebPort:     webPort,
-		Sandbox:     a.sandbox,
-		DockerSock:  dockerSock,
-		LogLevel:    a.logLevel,
-		JWTSecret:   jwtSecret,
+		DataDir:            dir,
+		ImageTag:           imageTag,
+		BackendPort:        backendPort,
+		WebPort:            webPort,
+		Sandbox:            a.sandbox,
+		DockerSock:         dockerSock,
+		LogLevel:           a.logLevel,
+		JWTSecret:          jwtSecret,
+		PersistenceBackend: a.persistenceBackend,
+		MemoryBackend:      a.memoryBackend,
 	}, nil
 }
 

cli/cmd/uninstall.go

@@ -9,6 +9,7 @@ import (
 	"runtime"
 	"strings"
 
+	"github.com/Aureliolo/synthorg/cli/internal/completion"
 	"github.com/Aureliolo/synthorg/cli/internal/config"
 	"github.com/Aureliolo/synthorg/cli/internal/docker"
 	"github.com/charmbracelet/huh"
@@ -59,6 +60,17 @@ func runUninstall(cmd *cobra.Command, _ []string) error {
 		return err
 	}
 
+	// Remove shell completion snippets for all supported shells
+	// (user may have installed completions for multiple shells).
+	_, _ = fmt.Fprintln(out, "Removing shell completions...")
+	for _, shell := range []completion.ShellType{
+		completion.Bash, completion.Zsh, completion.Fish, completion.PowerShell,
+	} {
+		if err := completion.Uninstall(ctx, shell); err != nil {
+			_, _ = fmt.Fprintf(cmd.ErrOrStderr(), "Warning: could not remove %s completions: %v\n", shell, err)
+		}
+	}
+
 	// Optionally remove CLI binary.
 	if err := confirmAndRemoveBinary(cmd); err != nil {
 		return err
@@ -113,57 +125,66 @@ func confirmAndRemoveData(cmd *cobra.Command, dataDir string) error {
 	if err := form.Run(); err != nil {
 		return err
 	}
+	if !removeData {
+		return nil
+	}
+	dir := filepath.Clean(dataDir)
+	if err := rejectUnsafeDir(dir); err != nil {
+		return err
+	}
+	return removeDataDir(cmd, dir)
+}
 
-	if removeData {
-		dir := filepath.Clean(dataDir)
-		// Safety: refuse to remove root, home, UNC share roots, or drive roots.
-		home, homeErr := os.UserHomeDir()
-		if homeErr != nil {
-			_, _ = fmt.Fprintf(cmd.ErrOrStderr(), "Warning: cannot determine home directory: %v\n", homeErr)
-		}
-		isHomeDir := false
-		if homeErr == nil {
-			home = filepath.Clean(home)
-			if runtime.GOOS == "windows" {
-				isHomeDir = strings.EqualFold(dir, home)
-			} else {
-				isHomeDir = dir == home
-			}
-		}
-		vol := filepath.VolumeName(dir)
-		// Only reject UNC share roots (e.g. \\server\share), not arbitrary
-		// paths under a UNC share (e.g. \\server\share\synthorg\data).
-		isUNCRoot := vol != "" &&
-			(strings.HasPrefix(vol, `\\`) || strings.HasPrefix(vol, "//")) &&
-			(dir == vol || dir == vol+`\` || dir == vol+"/")
-		isDriveRoot := len(dir) == 3 && dir[1] == ':' && (dir[2] == '\\' || dir[2] == '/')
-		if dir == "/" || isHomeDir || isDriveRoot || isUNCRoot {
-			return fmt.Errorf("refusing to remove %q — does not look like an app data directory", dir)
+// rejectUnsafeDir refuses to remove root, home, relative, UNC share roots, or drive roots.
+func rejectUnsafeDir(dir string) error {
+	if dir == "" || dir == "." || !filepath.IsAbs(dir) {
+		return fmt.Errorf("refusing to remove %q — must be an absolute path", dir)
+	}
+	home, homeErr := os.UserHomeDir()
+	isHomeDir := false
+	if homeErr == nil {
+		home = filepath.Clean(home)
+		if runtime.GOOS == "windows" {
+			isHomeDir = strings.EqualFold(dir, home)
+		} else {
+			isHomeDir = dir == home
 		}
+	}
+	vol := filepath.VolumeName(dir)
+	// Only reject UNC share roots (e.g. \\server\share), not arbitrary
+	// paths under a UNC share (e.g. \\server\share\synthorg\data).
+	isUNCRoot := vol != "" &&
+		(strings.HasPrefix(vol, `\\`) || strings.HasPrefix(vol, "//")) &&
+		(dir == vol || dir == vol+`\` || dir == vol+"/")
+	isDriveRoot := len(dir) == 3 && dir[1] == ':' && (dir[2] == '\\' || dir[2] == '/')
+	if dir == "/" || isHomeDir || isDriveRoot || isUNCRoot {
+		return fmt.Errorf("refusing to remove %q — does not look like an app data directory", dir)
+	}
+	return nil
+}
 
-		// On Windows the running binary cannot be deleted. If it lives
-		// inside the config directory, remove everything else and leave
-		// the binary for deferred cleanup in confirmAndRemoveBinary.
-		execPath, execErr := os.Executable()
-		if execErr != nil {
-			_, _ = fmt.Fprintf(cmd.ErrOrStderr(), "Warning: cannot resolve executable path: %v\n", execErr)
+// removeDataDir removes the data directory. On Windows, if the running
+// binary lives inside the directory, it removes everything except the binary.
+func removeDataDir(cmd *cobra.Command, dir string) error {
+	execPath, execErr := os.Executable()
+	if execErr != nil {
+		_, _ = fmt.Fprintf(cmd.ErrOrStderr(), "Warning: cannot resolve executable path: %v\n", execErr)
+	}
+	if execErr == nil {
+		if resolved, err := filepath.EvalSymlinks(execPath); err == nil {
+			execPath = resolved
 		}
-		if execErr == nil {
-			if resolved, err := filepath.EvalSymlinks(execPath); err == nil {
-				execPath = resolved
-			}
+	}
+	if execErr == nil && runtime.GOOS == "windows" && isInsideDir(execPath, dir) {
+		if err := removeAllExcept(dir, execPath); err != nil {
+			return fmt.Errorf("removing config directory: %w", err)
 		}
-		if execErr == nil && runtime.GOOS == "windows" && isInsideDir(execPath, dir) {
-			if err := removeAllExcept(dir, execPath); err != nil {
-				return fmt.Errorf("removing config directory: %w", err)
-			}
-			_, _ = fmt.Fprintf(cmd.OutOrStdout(), "Removed contents of %s (binary skipped — still running)\n", dir)
-		} else {
-			if err := os.RemoveAll(dir); err != nil {
-				return fmt.Errorf("removing config directory: %w", err)
-			}
-			_, _ = fmt.Fprintf(cmd.OutOrStdout(), "Removed %s\n", dir)
+		_, _ = fmt.Fprintf(cmd.OutOrStdout(), "Removed contents of %s (binary skipped — still running)\n", dir)
+	} else {
+		if err := os.RemoveAll(dir); err != nil {
+			return fmt.Errorf("removing config directory: %w", err)
 		}
+		_, _ = fmt.Fprintf(cmd.OutOrStdout(), "Removed %s\n", dir)
 	}
 	return nil
 }