-
Notifications
You must be signed in to change notification settings - Fork 1
feat: wire MultiAgentCoordinator into runtime #396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
92f73d7
feat: wire MultiAgentCoordinator into runtime
Aureliolo 96942eb
fix: address 30 review findings from 11 agents
Aureliolo 7af5438
fix: address 24 review findings from 19 sources
Aureliolo e801bea
fix: address review findings and fix mypy CI failure
Aureliolo 6d1daea
fix: address second round of review findings
Aureliolo 1edd0b4
fix: address third round of review findings
Aureliolo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
YAML structure appears incorrect: these fields belong at coordination level, not under auto_topology_rules.
Based on
CoordinationSectionConfig(seesection_config.py),max_concurrency_per_wave,fail_fast,enable_workspace_isolation, andbase_branchare top-level fields of the coordination section, not nested underauto_topology_rules. The current indentation suggests they're children ofauto_topology_rules.📝 Suggested fix
coordination: topology: "auto" # auto, sas, centralized, decentralized, context_dependent auto_topology_rules: # sequential tasks -> always single-agent sequential_override: "sas" # parallel tasks -> select based on domain structure parallel_default: "centralized" # mixed tasks -> SAS backbone for sequential phases, delegates parallel sub-tasks mixed_default: "context_dependent" # hybrid: not a single topology -- engine selects per-phase - max_concurrency_per_wave: null # None = unlimited - fail_fast: false - enable_workspace_isolation: true - base_branch: main + max_concurrency_per_wave: null # None = unlimited + fail_fast: false + enable_workspace_isolation: true + base_branch: mainNote: If the current indentation is intentional (2-space indent at coordination level), then the YAML is correct but the visual alignment is misleading. Consider adjusting for clarity.
🤖 Prompt for AI Agents