-
Notifications
You must be signed in to change notification settings - Fork 1
Update release version from 0.1.2 to 0.1.0 #288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,3 +1,3 @@ | ||||||||||
| { | ||||||||||
| ".": "0.1.2" | ||||||||||
| ".": "0.1.0" | ||||||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Version downgrade will conflict with existing git tags This change sets the Release Please manifest back to Release Please uses this manifest as its source of truth for "the last released version." After merging this PR:
If the intent is to cut a fresh release cycle starting from a clean base, the manifest should be set to
Suggested change
Prompt To Fix With AIThis is a comment left during a code review.
Path: .github/.release-please-manifest.json
Line: 2
Comment:
**Version downgrade will conflict with existing git tags**
This change sets the Release Please manifest back to `0.1.0`, but versions `0.1.1` and `0.1.2` have already been fully released — both `pyproject.toml` and `src/ai_company/__init__.py` are currently pinned to `"0.1.2"`, and git tags `v0.1.1` and `v0.1.2` exist in the repository.
Release Please uses this manifest as its source of truth for "the last released version." After merging this PR:
1. Release Please will calculate the next version by bumping from `0.1.0` (e.g. it will try to produce `0.1.1` again).
2. It will also attempt to rewrite `pyproject.toml` and `src/ai_company/__init__.py` (both listed as `extra-files` in `release-please-config.json`) from `0.1.2` back toward a `0.1.1`-era value.
3. When it tries to push a tag, the `v0.1.1` (and potentially `v0.1.2`) tag already exists — the release workflow will either fail or, worse, create a broken/duplicate release.
If the intent is to cut a fresh release cycle starting from a clean base, the manifest should be set to `0.1.2` (the actual last released version), not `0.1.0`. Downgrading the manifest value is not a supported Release Please operation and will corrupt the automated release pipeline.
```suggestion
".": "0.1.2"
```
How can I resolve this? If you propose a fix, please make it concise.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Downgrading the version from
Suggested change
|
||||||||||
| } | ||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The release-please manifest version is being downgraded to 0.1.0, but the repo currently advertises 0.1.2 in other release-tracked files (e.g., pyproject.toml and src/ai_company/init.py). This mismatch will likely cause Release Please to generate duplicate/incorrect next versions (e.g., v0.1.1) and can break the release/tagging pipeline. Align the manifest with the actual current released version (or, if intentionally resetting history, update all release-tracked files/tags consistently).