-
Notifications
You must be signed in to change notification settings - Fork 0
feat: deep CEO interview to project charter #2045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
02cc4ad
feat: deep CEO interview to project charter
Aureliolo f6de5e3
fix: harden Windows xdist node-down handling in the pre-push gate
Aureliolo 4347a56
fix: pre-PR review fixes (ownership fences, dispatcher hardening, web…
Aureliolo 3ce3bdc
fix: babysit round 3, 16 findings (15 reviewer + 1 ci)
Aureliolo 1b7b9cc
test: update charter cancel handler tests for admin guardrails
Aureliolo b6f68af
fix: switch CharterDraftCard resync from useEffect to key prop
Aureliolo 8480b2f
chore: regenerate DTOs after rebase onto cockpit + mission-control
Aureliolo 6f89dd4
fix: log CHARTER_STATE_INCONSISTENT before raise + functional updater…
Aureliolo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't downgrade repeated bare
node downcrashes to advisory.This path exits
0for any non-zero run that only emits[gwN] node down..., but the repeated-crash guard only counts_parse_worker_crashes()entries with test ids. If the same test tears a worker down on both--count 2iterations and xdist never printsworker ... crashed while running ..., the gate will still pass as advisory. That breaks the stated contract that “every replay” worker crashes must block.Also applies to: 683-707
🤖 Prompt for AI Agents