feat(storybook): enable changeDetection + trim web/CLAUDE.md

[Aureliolo]

Summary

Two opportunistic wins from the 2026-05-16 dependency bump, plus an unrelated web/CLAUDE.md density cleanup.

1. Storybook 10.4 features.changeDetection

Enabled in web/.storybook/main.ts. Tags stories in the sidebar as new / modified / affected based on git diff, with URL-persisted filters. Useful when running npm --prefix web run storybook during visual review of a feature branch.

2. Playwright 1.60 test.abort sweep

Audited all 12 files in web/e2e/ for throw new Error(...) candidates inside fixtures / route handlers / beforeEach / beforeAll. Result: zero migrations.

The only throw new Error(...) across the suite lives at web/e2e/fixtures/websocket-harness.ts:116, inside a page.evaluate(...) callback. That callback runs in the browser context, where test from @playwright/test is not in scope. The existing throw already surfaces clearly as an EvaluationError, so leaving as-is is the right call.

3. web/CLAUDE.md trim (152 → 106 lines)

Driven by the principle that CLAUDE.md is for MANDATORY rules and non-obvious gotchas, not a feature changelog or reference catalog.

Removed:

• ## Performance Benchmarks section (implementation detail of bench.ts + bundle-size).
• SSE-fallback behaviour paragraph from the Zustand section (described behaviour, not a rule).
• ## Base UI Adoption Decisions section (reference catalog; still linked from docs/reference/).
• 16-bullet ### Component reuse: don't recreate these inline catalog (replaced with 2-bullet ### Anti-patterns (lint-enforced) keeping only icon-helpers + viewport-size, both of which tie to actual ESLint rules).

Condensed:

• App.tsx CSP nonce intro paragraph.
• Package Structure section.
• Generated DTO types paragraph (kept the rule: "never hand-edit *.gen.ts; regenerate via scripts/generate_dto_types_ts.py").

Test plan

• npm --prefix web run storybook:build ✅ — confirms features.changeDetection is a valid Storybook 10.4 flag (no unknown-feature error).
• npm --prefix web run lint ✅ — no fallout.
• No Python / Go scope touched, so backend / CLI suites not run.

Review coverage

Pre-reviewed by 3 agents (docs-consistency, comment-quality-rot, tool-parity-checker); 0 findings.

• docs-consistency: verified all outbound links in trimmed web/CLAUDE.md resolve, and that docs/reference/web-base-ui-decisions.md is still linked from 3 other reference pages (not orphaned).
• comment-quality-rot: clean (no reviewer citations, no #N back-refs, no migration framing in commits or diff).
• tool-parity-checker: clean (opencode.json still includes web/CLAUDE.md in instructions[]; no .opencode/ references to removed sections).

[github-actions]

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 8708ec80-b2f0-4e8b-b5fe-952786eba80d

📥 Commits

Reviewing files that changed from the base of the PR and between d19fae5 and 8c50e13.

📒 Files selected for processing (2)

• web/.storybook/main.ts
• web/CLAUDE.md

📜 Recent review details

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)

• GitHub Check: Build Web Assets (melange)
• GitHub Check: Lighthouse Dashboard
• GitHub Check: CodSpeed Web benchmarks
• GitHub Check: Dashboard Test
• GitHub Check: Analyze (python)

🧰 Additional context used

📓 Path-based instructions (1)

**/*.{md,rst}

📄 CodeRabbit inference engine (CLAUDE.md)

Numerics in README and public docs sourced from data/runtime_stats.yaml via <!--RS:NAME--> markers per data/README.md

Files:

• web/CLAUDE.md

🧠 Learnings (1)

📓 Common learnings

Learnt from: CR
Repo: Aureliolo/synthorg

Timestamp: 2026-05-16T16:45:04.216Z
Learning: Bump the WebSocket protocol version on both client and server sides together for breaking payload changes; drift is enforced at pre-commit/pre-push by `scripts/check_ws_protocol_version_in_sync.py`

Learnt from: CR
Repo: Aureliolo/synthorg

Timestamp: 2026-05-16T16:45:04.216Z
Learning: The error codes generator (`scripts/generate_error_codes_ts.py`) reads `src/synthorg/core/error_taxonomy.py`; drift is enforced at pre-push by `scripts/check_error_codes_ts_in_sync.py`

Learnt from: CR
Repo: Aureliolo/synthorg

Timestamp: 2026-05-16T16:45:04.216Z
Learning: Run lint via `npm --prefix web run lint` with `--max-warnings 0` enforced; enumerate stale `eslint-disable` directives with `--report-unused-disable-directives-severity=warn`

Learnt from: CR
Repo: Aureliolo/synthorg

Timestamp: 2026-05-16T16:45:04.216Z
Learning: The PostToolUse hook (`scripts/check_web_design_system.py`) runs on every `web/src/` edit and flags hardcoded hex/rgba/fonts/Motion durations/locale literals/bare `.toLocale*String()` calls/missing Storybook stories/duplicate component patterns/complex `.map()` blocks; fix every violation before proceeding

🔇 Additional comments (2)

web/CLAUDE.md (1)

3-3: LGTM!

Also applies to: 27-27, 60-60, 84-87

web/.storybook/main.ts (1)

10-12: ⚡ Quick win

No issues found. The changeDetection feature flag is valid and correctly configured in Storybook 10.4.

---

Walkthrough

This PR updates Storybook's configuration to enable the changeDetection feature and restructures the developer guidelines in CLAUDE.md. The Storybook change adds a features block to enable change detection during story rendering. The documentation updates condense the CSP/dashboard description, introduce a new "Package Structure" section with benchmark constraints, clarify error-handling and DTO policies, replace the component-reuse anti-pattern list with lint-enforced rules for icon helpers and viewport queries, and add a new "Post-Training Reference" section covering TypeScript 6 and Storybook 10 gotchas.

Suggested labels

autorelease: tagged

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately captures the two main changes: enabling Storybook's changeDetection feature and trimming web/CLAUDE.md documentation.
Description check	✅ Passed	The description provides comprehensive context for all changes in the PR, including the Storybook feature enablement, Playwright audit results, and detailed rationale for CLAUDE.md trimming.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[gemini-code-assist]

Code Review

This pull request enables change detection in the Storybook configuration and refactors the web/CLAUDE.md file to condense documentation and remove redundant implementation details. Feedback was provided regarding the consolidation of performance benchmarks into the 'Package Structure' section, noting that the content is now unrelated to the header and suggesting a more inclusive title for better organization.

[gemini-code-assist]

The content added to this section (benchmarks and bundle-size budgets) is unrelated to 'Package Structure'. Consider renaming the header to reflect the combined scope or keeping the separate 'Performance Benchmarks' header to maintain logical organization and discoverability for the agent.

Suggested change

	## Package Structure
	## Performance & Package Structure

[codspeed-hq]

Merging this PR will not alter performance

✅ 21 untouched benchmarks
⏩ 33 skipped benchmarks¹

---

_{Comparing feat/storybook-changedetection-playwright-abort (8c50e13) with main (7368685)²}

Footnotes

1. 33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

2. No successful run was found on main (d19fae5) during the generation of this report, so 7368685 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩