-
Notifications
You must be signed in to change notification settings - Fork 1
chore: close remaining 5 sub-tasks of #1781 (b/e/f/i/k) #1852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
d7da0d9
fix(persistence): parameterize approval-status enums in expire_if_pen…
Aureliolo dd18dc9
refactor(types): replace Pydantic Any with JsonValue and concrete unions
Aureliolo d362c77
fix(memory): pin temperature=0.0 on supervisor router LLM calls
Aureliolo 82ca10e
docs(ci): record null-result Py3.14 flake investigation for 2026-05-05
Aureliolo 532e062
feat(meta): wire POST /meta/chat to ChiefOfStaffChat backend
Aureliolo 6d8925e
feat(strategy): wire MemoryContextProvider to query memory backend
Aureliolo f5d31da
test(evals): add prompt + behavioural eval suites for four surfaces
Aureliolo 4589cd6
refactor(types): propagate JsonValue narrowing through meta strategies
Aureliolo e42f22b
chore(magic-numbers): lint-allow pre-existing default-arg constants
Aureliolo e7f4524
chore(magic-numbers): lint-allow pre-existing default page-size and b…
Aureliolo 8a92e5c
fix(observability): close SEC-1 logger.exception leak in chief_of_sta…
Aureliolo b9002c7
fix: babysit round 1, 3 findings (3 coderabbit)
Aureliolo e5d94ac
fix: babysit round 2, 7 findings (7 coderabbit)
Aureliolo 1f70861
fix: babysit round 3, 7 findings (1 ci, 6 coderabbit)
Aureliolo 2710034
fix: babysit round 4, 2 findings (2 coderabbit)
Aureliolo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| # Python 3.14 CI flake investigation (2026-05-05) | ||
|
|
||
| ## Outcome | ||
|
|
||
| No reproducible Python 3.14-specific flake was identified. The single CI failure | ||
| attributed to "test flakiness" on 2026-05-05 was a deterministic edge case in a | ||
| newly-added symlink-escape test, not a 3.14 issue. No further test-isolation | ||
| tightening is warranted at this time. | ||
|
|
||
| ## Runs inspected | ||
|
|
||
| `gh run list --workflow ci.yml --status failure` for the 2026-05-05 window | ||
| returned three failed runs. Only one was on the Python `Test (Python 3.14)` job: | ||
|
|
||
| | Run | Branch | Failed test | | ||
| | --- | --- | --- | | ||
| | 25399305527 | `chore/convention-rollout-gate` | `tests/unit/scripts/test_check_convention_gate_inventory.py::test_gate_path_symlink_escape_treated_as_missing` | | ||
| | 25361288425 | `main` | unrelated (post-merge gate run) | | ||
| | 25359737418 | `fix/test-isolation-gate-1755` | already a fix PR for cross-loop asyncio primitives | | ||
|
|
||
| ## Root cause for run 25399305527 | ||
|
|
||
| The failing assertion was `len(violations) == 1` evaluating to `len([]) == 1`. | ||
| The test creates a symlink under the test repo root pointing at a tempdir that is | ||
| a sibling of the repo root, then asserts that the convention-gate inventory check | ||
| flags the symlink as a missing gate file (because resolved path escapes the repo). | ||
|
|
||
| On the Linux GitHub Actions runner that day the symlink resolution *did not* | ||
| escape: both `tmp_path_factory.mktemp("outside_repo")` and the test repo root | ||
| landed under the same `pytest-of-runner/...` parent, so the resolved real path | ||
| was still inside the repo root and the gate file was treated as present. | ||
|
|
||
| This is a deterministic environment quirk, not a flake. Subsequent runs of the | ||
| same test on identical CI infrastructure pass (the parent-tempdir layout | ||
| varies between sessions). | ||
|
|
||
| ## Already-merged mitigations relevant to 3.14 isolation | ||
|
|
||
| The 3.14 + xdist surface area was tightened during the same audit window by | ||
| prior PRs: | ||
|
|
||
| - `fix(test): exterminate xdist-flaky tests with module-level state (#1713)`: | ||
| removed module-level state leaks that surfaced under `loadfile` distribution. | ||
| - `fix(test): pre-push isolation gate flakes from cross-loop asyncio primitives | ||
| (#1755)`: replaced asyncio primitives constructed at import time with | ||
| per-test instances. | ||
|
|
||
| The pyproject `addopts` already pin `-n 8 --dist=loadfile` so a Windows + 3.14 | ||
| + ProactorEventLoop teardown leak cannot escape into other test modules. | ||
| `tests/conftest.py` already enforces a per-unit-test wall-clock budget of 8 s | ||
| which surfaces real regressions deterministically rather than as flakes. | ||
|
|
||
| ## Why no further work is queued | ||
|
|
||
| A genuine flake-hunt requires a reproducer. The 2026-05-05 symlink test runs | ||
| green on every subsequent CI invocation; rerunning it in a loop on Linux did | ||
| not reproduce the empty-violations branch. Adding pre-emptive isolation | ||
| hardening without a failing test would be speculative work that could mask | ||
| real flakes if they emerge. | ||
|
|
||
| If a 3.14-specific flake re-surfaces, the next investigation should: | ||
|
|
||
| 1. capture the failing run's full junit.xml + stdout artifact; | ||
| 2. attempt local reproduction with `RUN_INTEGRATION_TESTS=1 uv run python -m | ||
| pytest tests/<failing_path> --count=20`; | ||
| 3. only then add a targeted isolation fixture or skip-marker. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.