-
Notifications
You must be signed in to change notification settings - Fork 0
feat: implement multi-project support -- engine orchestration (#242) #1153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
a585d1f
feat: implement multi-project support -- engine orchestration (#242)
Aureliolo e720759
fix: address review findings -- error handling, security, docs
Aureliolo a0aedf6
fix: address 13 PR review findings from Gemini, Copilot, CodeRabbit, …
Aureliolo 9e1a639
fix: address CodeRabbit round 2 -- project_id typing, missing-repo wa…
Aureliolo 07683dc
fix: propagate project exceptions from resume path through _apply_rec…
Aureliolo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,6 +18,7 @@ | |
| BUDGET_DOWNGRADE_APPLIED, | ||
| BUDGET_DOWNGRADE_SKIPPED, | ||
| BUDGET_HARD_STOP_TRIGGERED, | ||
| BUDGET_PROJECT_BUDGET_EXCEEDED, | ||
| BUDGET_TASK_LIMIT_HIT, | ||
| BUDGET_TIER_PRESERVED, | ||
| ) | ||
|
|
@@ -256,6 +257,9 @@ def _build_checker_closure( # noqa: PLR0913 | |
| daily_baseline: float, | ||
| thresholds: _AlertThresholds, | ||
| agent_id: str, | ||
| project_budget: float = 0.0, | ||
| project_baseline: float = 0.0, | ||
| project_id: str | None = None, | ||
| ) -> BudgetChecker: | ||
| """Build the sync budget checker closure. | ||
|
|
||
|
|
@@ -267,6 +271,10 @@ def _build_checker_closure( # noqa: PLR0913 | |
| daily_baseline: Pre-computed daily spend at task start. | ||
| thresholds: Pre-computed alert thresholds. | ||
| agent_id: Agent identifier for logging. | ||
| project_budget: Total project budget (0 = disabled). | ||
| project_baseline: Pre-computed project spend at task start. | ||
| project_id: Project identifier for logging (None when | ||
| project budget is disabled). | ||
|
|
||
| Returns: | ||
| Sync callable returning ``True`` when budget is exhausted. | ||
|
|
@@ -277,6 +285,13 @@ def _check(ctx: AgentContext) -> bool: | |
| running_cost = ctx.accumulated_cost.cost_usd | ||
| return ( | ||
| _check_task_limit(running_cost, task_limit, agent_id) | ||
| or _check_project_limit( | ||
| running_cost, | ||
| project_budget, | ||
| project_baseline, | ||
| agent_id, | ||
| project_id, | ||
| ) | ||
| or _check_monthly_limit( | ||
| running_cost, | ||
| monthly_budget, | ||
|
|
@@ -378,3 +393,29 @@ def _check_daily_limit( | |
| ) | ||
| return True | ||
| return False | ||
|
|
||
|
|
||
| def _check_project_limit( | ||
| running_cost: float, | ||
| project_budget: float, | ||
| project_baseline: float, | ||
| agent_id: str, | ||
| project_id: str | None = None, | ||
| ) -> bool: | ||
| """Return True if project budget is exhausted.""" | ||
| if project_budget <= 0: | ||
| return False | ||
| total_project = round( | ||
| project_baseline + running_cost, | ||
| BUDGET_ROUNDING_PRECISION, | ||
| ) | ||
| if total_project >= project_budget: | ||
| logger.warning( | ||
| BUDGET_PROJECT_BUDGET_EXCEEDED, | ||
| agent_id=agent_id, | ||
| project_id=project_id, | ||
| total_project=total_project, | ||
| project_budget=project_budget, | ||
| ) | ||
| return True | ||
|
Comment on lines
+398
to
+420
|
||
| return False | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Project budget checks miss concurrent spend.
running_costhere is the current execution'sctx.accumulated_cost.cost_usd, so each closure only sees its own in-flight spend. If two agents run in the same project concurrently, both can reuse the sameproject_baselinesnapshot and stay underproject_budgetindividually while the combined project total overshoots it. That makes this a best-effort per-execution stop, not a true project-wide in-flight limit.Please compare against a shared project accumulator/live tracker instead of
project_baseline + local running_cost.Also applies to: 397-420
🤖 Prompt for AI Agents