This repository has been archived by the owner on Jun 24, 2021. It is now read-only.
Compability for .NET Core 3.0 (preview 6) #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR should be the solution for #11. |
src/Discord.OAuth2/DiscordHandler.cs
Outdated
| @@ -28,9 +28,9 @@ protected override async Task<AuthenticationTicket> CreateTicketAsync(ClaimsIden | |||
| if (!response.IsSuccessStatusCode) | |||
| throw new HttpRequestException($"Failed to retrieve Discord user information ({response.StatusCode})."); | |||
|
|
|||
| var payload = JObject.Parse(await response.Content.ReadAsStringAsync()); | |||
| var payload = JsonDocument.Parse(await response.Content.ReadAsStringAsync()); | |||
There was a problem hiding this comment.
The new JsonDocument type implements IDisposable, so you should add a using here:
There was a problem hiding this comment.
The new
JsonDocumenttype implementsIDisposable, so you should add ausinghere:
I hope it's OK to use the root element (JsonElement) outside the disposed scope?
See a3177e1
There was a problem hiding this comment.
I don’t think so. It should be disposed when you’ve finished reading anything from it. If you look at the Microsoft OAuth providers for 3.0 they do the same as the code in the link I posted.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In accordance with dotnet/aspnetcore#3756 and dotnet/aspnetcore#3612 this pull requests creates compability for .NET Core 3.0.
This PR contains the breaking change that the library has to target .NET Core 3.0.
Primary changes in
Discord.OAuth2.csprojandDiscordHandler.cs.Changes in
Discord.OAuth2.targetsare optional, eventually to be replaced later.