chat: make trailing newline optional after assistant tag in Laguna pa… - #59
Closed
ghost wants to merge 1 commit into
Closed
chat: make trailing newline optional after assistant tag in Laguna pa…#59ghost wants to merge 1 commit into
ghost wants to merge 1 commit into
Conversation
…rser Strictly requiring a trailing newline after <assistant> causes parsing stalls when client templates format prompts differently or when the model omits the newline. Allowing optional spacing/newlines prevents parser locks.
Repository owner
closed this by deleting the head repository
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR relaxes the Laguna assistant generation prompt parsing template in
common/chat.cppto make the trailing newline after the<assistant>tag optional instead of strictly required.Symptoms / Issues Resolved
Without this patch:
<assistant>or adding spaces), the PEG parser fails to match the template.<assistant>\nliteral, the server hangs indefinitely or fails to return the reasoning block.This fix makes the Laguna parser robust against formatting differences, allowing successful prompt template matching whether a trailing newline, trailing spaces, or nothing follows the
<assistant>tag.Technical Changes
const std::string GEN_PROMPT = "<assistant>\n"string literal matching with a flexible regex-style pattern:auto gen_prompt = p.literal("<assistant>") + p.optional(p.space());extract_reasoning) to use the newgen_promptparser rule.Requirements