Skip to content

fix: Gemma 4 + TurboQuant KV no longer crashes on second prompt when --cache-reuse enabled #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ooooze merged 1 commit into from
May 12, 2026
Merged

fix: Gemma 4 + TurboQuant KV no longer crashes on second prompt when --cache-reuse enabled #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/llama-kv-cache.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1315,6 +1315,8 @@ uint32_t llama_kv_cache::get_n_stream() const {
}

bool llama_kv_cache::get_has_shift() const {
// TurboQuant uses kernel-level WHT rotation -- position shift is a no-op
if (!layers.empty() && (layers[0].k->type == GGML_TYPE_TURBO2_0 || layers[0].k->type == GGML_TYPE_TURBO3_0 || layers[0].k->type == GGML_TYPE_TURBO4_0)) { return false; }
bool result = false;

for (uint32_t s = 0; s < n_stream; ++s) {
Expand Down Expand Up @@ -2070,6 +2072,8 @@ ggml_cgraph * llama_kv_cache::build_graph_shift(llm_graph_result * res, llama_co

for (const auto & layer : layers) {
const uint32_t il = layer.il;
const bool is_turbo_k = (layer.k->type == GGML_TYPE_TURBO2_0 || layer.k->type == GGML_TYPE_TURBO3_0 || layer.k->type == GGML_TYPE_TURBO4_0);
if (is_turbo_k) { continue; }

const int64_t n_head_kv = hparams.n_head_kv(il);
const int64_t n_embd_k_gqa = hparams.n_embd_k_gqa(il);
Expand Down