This repository has been archived by the owner on Aug 7, 2023. It is now read-only.
Parse tslint.json using the configured linter. #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the linter configuration (tslint.json) is located and parsed using the tslint module packaged with the plugin. This is incorrect when another version of tslint is in use, which happens when useLocalTslint is true, and a suitable tslint version is found.
|
Thanks for the fix! |
|
Published in v0.9.3 🎉. |
|
@Arcanemagus Thank you very much for the quick turnaround! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the linter configuration (tslint.json) is located and parsed using the tslint module packaged with the plugin. This is incorrect when another version of tslint is in use, which happens when useLocalTslint is true, and a suitable tslint version is found.
This is preventing me from using this atom plugin, because I'm using a tslint version that allows comments in the JSON configuration, but the tslint packaged with atom doesn't support that yet. In any case, it seems wrong to parse the configuration with one version of tslint, and then use it with another version.
Please consider merging this, and thank you very much for your work on this plugin!