This repository has been archived by the owner on Aug 7, 2023. It is now read-only.
Update Linter.findConfiguration's first parameter to null #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, `Linter.findConfiguration` is called with `undefined` as its first parameter. This bypasses `tslint`'s configuration-finding logic, as it explicitly checks for a `null` first parameter. Therefore one cannot use `tslint`'s option to set a `tslintConfig` attribute in `package.json`. This PR corrects that behavior.
Phylodome
changed the title
Linter.findConfiguration's first parameter to null
|
That is just plain bizarre that it was written like that, this PR looks good to me though! |
Arcanemagus
added a commit
that referenced
this pull request
Dec 10, 2015
Update Linter.findConfiguration's first parameter to null
|
Released in v0.5.1. |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
Linter.findConfigurationis called withundefinedasits first parameter. This bypasses
tslint's configuration-findinglogic, as it explicitly checks for a
nullfirst parameter. Thereforeone cannot use
tslint's option to set atslintConfigattribute inpackage.json. This PR corrects that behavior.