This repository was archived by the owner on Aug 7, 2023. It is now read-only.
support tslint@5 #151
Merged
support tslint@5 #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It uses the rules severity if there (if the project uses tslint@5), but defaults to warning, like before.
Xapphire13
reviewed
Apr 7, 2017
lib/main.js
Outdated
| if (pkg.version.startsWith('3')) { | ||
| // eslint-disable-next-line import/no-dynamic-require | ||
| linter = shim(require('loophole').allowUnsafeNewFunction(() => require(linterPath))); | ||
| } else if (pkg.version.startsWith('4')) { | ||
| } else if (pkg.version.startsWith('4') || pkg.version.startsWith('5')) { |
There was a problem hiding this comment.
I feel that the else if is redundant since we only hit this code if we are version 3, 4 or 5 and have an explicit if for the 3 case. It can safely be replaced with a simple else
There was a problem hiding this comment.
I agree, if a future v6 requires another change we can make this explicit again there.
There was a problem hiding this comment.
Thanks peeps, changed it to a simple else. 👍
|
Please merge master into your topic branch and add a new iteration fixing the merge conflicts |
|
@Xapphire13 Thank you for doing this. I haven't come around to it sadly. 👏 |
|
No worries, I'm super keen to get TSLint 5 support =] |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It uses the rules severity if there (if the project uses tslint@5), but defaults to warning, like before.