Skip to content
This repository has been archived by the owner on Aug 7, 2023. It is now read-only.

export filePath to environment #77

Closed
wants to merge 1 commit into from
Closed

export filePath to environment #77

wants to merge 1 commit into from

Conversation

GheRivero
Copy link
Contributor

exposing the file path to the environment makes easier to have a script to call flake8 with custom parameters

exposing the file path to the environment makes easier to have a script to call flake8 with custom parameters
@steelbrain
Copy link
Contributor

Instead of setting our current process's env, You should pass it like helpers.exec(filePath, [], {env: {FILE_PATH: "/path/to/file"}})

@steelbrain steelbrain self-assigned this Sep 9, 2015
@steelbrain steelbrain assigned Arcanemagus and unassigned steelbrain Oct 8, 2015
@Arcanemagus
Copy link
Member

@GheRivero can you please address @steelbrain's comments? Since it's been a month if I get time I'll just implement this correctly and close this if I haven't heard back from you by then.

@Arcanemagus
Copy link
Member

The scripts should now be running with the current directory set to that of the file, as such I'm going to close this PR.

@GheRivero if you have a use case that this doesn't fix please make your case why we should be polluting the runtime environment with extra variables 😛.

@Arcanemagus Arcanemagus closed this Oct 8, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants