Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPAG and expansion pass organise/before #144

Merged
merged 20 commits into from
Feb 7, 2020
Merged

Conversation

AksanDotDev
Copy link
Contributor

General SPAG and formatting pass of the marked section, includes some page expansion to Side Events and aims to improve judging with reference to #104. Bundled due to the minor changes to most pages.

Spelling Punctuation and Grammar, minor revisions
Spelling, punctuation and grammar, additional revising price point guidance as the current seemed nonsensical, language strange. (Top tier being the cheapest.)
Spelling, Punctuation and Grammar and unbreaking a link, clarified a non standard term in context.
Spelling, Punctuation, Grammar and tidying
Cleaned up links, made some sentences make sense, spelling, punctuation and grammar.
Fixed the strange phrasing in regards to crime.
Minor touch up
Fixed a broken line, removed an unneeded sentence and reduced the highlighted size of a link.
Expanding in reference to issue Athons#104
Spelling, Punctuation and Grammar, corrected formatting and added STKRS as a provider.
Missed the slash
Minor expansion of content including societies, added an additional link, improved the readability of werewolf.
Spelling, punctuation, minor style and link improvments.
Bring local up to date
Copy link
Contributor

@robzwolf robzwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So pleased to see this PR, I've been meaning to do a full SPaG pass of the site but never had a chance.

I've left a couple of comments about really minor SPaG things, and one or two points to think about for judging.

docs/organise/before/catering.md Outdated Show resolved Hide resolved
docs/organise/before/finance.md Outdated Show resolved Hide resolved
docs/organise/before/finance.md Outdated Show resolved Hide resolved
docs/organise/before/gettingstarted.md Outdated Show resolved Hide resolved
docs/organise/before/judging.md Outdated Show resolved Hide resolved
docs/organise/before/judging.md Outdated Show resolved Hide resolved
docs/organise/before/stash_and_swag.md Outdated Show resolved Hide resolved
@AksanDotDev
Copy link
Contributor Author

Thanks @robzwolf the joys of having done this with no spell check. All the notes seem solid and I'll bring them in when I'm back at a keyboard tomorrow.

Correcting emergency.
I'm bad okay, correcting further capitalisation.
I before E except after C
Reduced recommended presentation times to 3-5 minutes and corrected Devpost
githib->Github->GitHub
@AksanDotDev
Copy link
Contributor Author

Updated with those changes @robzwolf

@AksanDotDev AksanDotDev requested a review from robzwolf February 7, 2020 13:16
Copy link
Contributor

@robzwolf robzwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid work on this PR! Approved 🙌

@robzwolf robzwolf merged commit 853b167 into Athons:master Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants