Skip to content

Laravel 10.x Compatibility#328

Merged
Gummibeer merged 3 commits intoAstrotomic:mainfrom
laravel-shift:l10-compatibility
Feb 21, 2023
Merged

Laravel 10.x Compatibility#328
Gummibeer merged 3 commits intoAstrotomic:mainfrom
laravel-shift:l10-compatibility

Conversation

@laravel-shift
Copy link
Copy Markdown
Contributor

This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 9.x.

Before merging, you need to:

  • Checkout the l10-compatibility branch
  • Review all comments for additional changes
  • Thoroughly test your package

If you do find an issue, please report it by commenting on this PR to help improve future automation.

@laravel-shift
Copy link
Copy Markdown
Contributor Author

⚠️ Shift updated your build matrix for Laravel 10. However, since you are supporting older versions of Laravel, you need to add the following exclusions:

exclude:
  - laravel: 10.*
    php: 8.0

@laravel-shift
Copy link
Copy Markdown
Contributor Author

⚠️ Shift detected GitHub Actions which run jobs using a version matrix. Shift attempted to update your configuration for Laravel 10. However, you should review these changes to ensure the desired combination of versions are built for your package.

@laravel-shift
Copy link
Copy Markdown
Contributor Author

⚗️ Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch.

To do so, temporarily add Shift's fork to the repositories property of your composer.json:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/laravel-shift/laravel-translatable.git"
        }
    ]
}

Then update your dependency constraint to reference this branch:

{
    "require": {
        "astrotomic/laravel-translatable": "dev-l10-compatibility",
    }
}

Finally, run: composer update

@ifox
Copy link
Copy Markdown

ifox commented Feb 15, 2023

Hi @Gummibeer, it would be great to review and merge this. Let me know if I can help. Cheers!

@antonioribeiro
Copy link
Copy Markdown

Hey @Gummibeer, I can help too, if you need, thank you!

@ordago ordago mentioned this pull request Feb 17, 2023
@Gummibeer Gummibeer merged commit 94611ab into Astrotomic:main Feb 21, 2023
@Gummibeer
Copy link
Copy Markdown
Member

https://github.com/Astrotomic/laravel-translatable/releases/tag/v11.12.0

@Gummibeer Gummibeer self-assigned this Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants