Repository navigation
fix: remove Review plus button #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -43,6 +43,10 @@ export function makeRightPanelResizeHandler( | |||||||||||||
| } | ||||||||||||||
| } | ||||||||||||||
|
|
||||||||||||||
| export function shouldShowReviewFileOpenButton(activeTab: string | undefined): boolean { | ||||||||||||||
| return activeTab !== "review" | ||||||||||||||
| } | ||||||||||||||
|
|
||||||||||||||
| type RightPanelShellIconName = "status" | "folder" | "review" | "terminal" | ||||||||||||||
|
|
||||||||||||||
| function RightPanelShellIcon(props: { icon: RightPanelShellIconName }) { | ||||||||||||||
|
|
@@ -188,6 +192,27 @@ export function SessionSidePanel(props: { | |||||||||||||
| }) | ||||||||||||||
| } | ||||||||||||||
|
|
||||||||||||||
| const fileOpenButton = (className: string) => ( | ||||||||||||||
| <Show when={shouldShowReviewFileOpenButton(activeTab())}> | ||||||||||||||
| <div class={className}> | ||||||||||||||
| <TooltipKeybind | ||||||||||||||
| title={language.t("command.file.open")} | ||||||||||||||
| keybind={command.keybind("file.open")} | ||||||||||||||
| class="flex items-center" | ||||||||||||||
| > | ||||||||||||||
| <IconButton | ||||||||||||||
| icon="plus-small" | ||||||||||||||
| variant="ghost" | ||||||||||||||
| iconSize="large" | ||||||||||||||
| class="!rounded-md" | ||||||||||||||
| onClick={() => openFilePicker(showAllFiles)} | ||||||||||||||
| aria-label={language.t("command.file.open")} | ||||||||||||||
| /> | ||||||||||||||
| </TooltipKeybind> | ||||||||||||||
| </div> | ||||||||||||||
| </Show> | ||||||||||||||
| ) | ||||||||||||||
|
|
||||||||||||||
| createEffect(() => { | ||||||||||||||
| if (!file.ready()) return | ||||||||||||||
|
|
||||||||||||||
|
|
@@ -292,22 +317,7 @@ export function SessionSidePanel(props: { | |||||||||||||
| <Show | ||||||||||||||
| when={showSecondaryReviewTabs()} | ||||||||||||||
| fallback={ | ||||||||||||||
| <div class="w-full bg-background-stronger flex items-center justify-end px-3 py-1.5"> | ||||||||||||||
| <TooltipKeybind | ||||||||||||||
| title={language.t("command.file.open")} | ||||||||||||||
| keybind={command.keybind("file.open")} | ||||||||||||||
| class="flex items-center" | ||||||||||||||
| > | ||||||||||||||
| <IconButton | ||||||||||||||
| icon="plus-small" | ||||||||||||||
| variant="ghost" | ||||||||||||||
| iconSize="large" | ||||||||||||||
| class="!rounded-md" | ||||||||||||||
| onClick={() => openFilePicker(showAllFiles)} | ||||||||||||||
| aria-label={language.t("command.file.open")} | ||||||||||||||
| /> | ||||||||||||||
| </TooltipKeybind> | ||||||||||||||
| </div> | ||||||||||||||
| fileOpenButton("w-full bg-background-stronger flex items-center justify-end px-3 py-1.5") | ||||||||||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||||||||||||||
| } | ||||||||||||||
| > | ||||||||||||||
| <Tabs.List | ||||||||||||||
|
|
@@ -357,22 +367,9 @@ export function SessionSidePanel(props: { | |||||||||||||
| <SortableProvider ids={openedTabs()}> | ||||||||||||||
| <For each={openedTabs()}>{(tab) => <SortableTab tab={tab} onTabClose={tabs().close} />}</For> | ||||||||||||||
| </SortableProvider> | ||||||||||||||
| <div class="bg-background-stronger h-full shrink-0 sticky right-0 z-10 flex items-center justify-center pr-3"> | ||||||||||||||
| <TooltipKeybind | ||||||||||||||
| title={language.t("command.file.open")} | ||||||||||||||
| keybind={command.keybind("file.open")} | ||||||||||||||
| class="flex items-center" | ||||||||||||||
| > | ||||||||||||||
| <IconButton | ||||||||||||||
| icon="plus-small" | ||||||||||||||
| variant="ghost" | ||||||||||||||
| iconSize="large" | ||||||||||||||
| class="!rounded-md" | ||||||||||||||
| onClick={() => openFilePicker(showAllFiles)} | ||||||||||||||
| aria-label={language.t("command.file.open")} | ||||||||||||||
| /> | ||||||||||||||
| </TooltipKeybind> | ||||||||||||||
| </div> | ||||||||||||||
| {fileOpenButton( | ||||||||||||||
| "bg-background-stronger h-full shrink-0 sticky right-0 z-10 flex items-center justify-center pr-3", | ||||||||||||||
| )} | ||||||||||||||
|
Comment on lines
+370
to
+372
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Use the refactored
Suggested change
|
||||||||||||||
| </Tabs.List> | ||||||||||||||
| </Show> | ||||||||||||||
| </div> | ||||||||||||||
|
|
||||||||||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In SolidJS, it is more idiomatic to define reusable UI pieces as components (capitalized) rather than functions that return JSX. This improves readability and follows the project's convention (e.g.,
RightPanelShellIcon). Additionally, using theclassprop name is more consistent with SolidJS thanclassName.