fix: keep tar archive paths local - #723
Conversation
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request introduces a localTarArchive utility to handle tar operations in a cross-platform manner, specifically addressing issues with Windows drive letters by executing commands within the target directory using relative paths. Feedback suggests improving the platform simulation logic in localTarArchive by using path.posix as a fallback instead of the default path module to ensure consistent behavior during cross-platform testing.
Summary
Fix
sync-officecli-skillstar invocations so local tarball paths are passed totaras./<basename>from the tarball directory instead of as absolute archive paths.Why
Current
devhas required CI green after #717, butwindows-advisory / unit-windows-desktopstill fails in the OfficeCLI skills sync tests. On Windows, GNU tar treats absolute paths likeD:\...\bundle.tar.gzorC:\...\bundle.tar.gzas remotehost:filearchive syntax, producing errors such asCannot connect to D: resolve failed.Related Issue
No linked issue. This is a focused follow-up to the failing
windows-advisoryrun on currentdevheadd5e6186cca6adca930793872892e26e8cdf67e07.Human Review Status
Pending. A human should make the final merge decision after reviewing the final diff and verification evidence.
Review Focus
Please check that
localTarArchive()is the right boundary: both extraction and the test helper's fixture tarball creation now avoid passing drive-letter archive paths directly totar.Risk Notes
Low. This only changes how the maintenance script calls local
tar; archive contents and sync behavior are unchanged. Windows impact is the main target. macOS/Linux keep using standardtarwith a directory-local archive argument.How To Verify
Screenshots or Recordings
Not applicable. No visible UI change.
Checklist
bug,enhancement,task, ordocumentation), at least one primary routing label (app,ui,platform,harness, orci), and exactly one priority label (P0toP3), or I requested maintainer labelingdev, and my PR title and commit messages use Conventional Commits in English