-
Notifications
You must be signed in to change notification settings - Fork 14
ci: lint PR conventions and polish CI workflows #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
fe8659a
docs(ci): document why setup-node is load-bearing (#70)
Astro-Han ff2ac34
ci: lint PR titles against Conventional Commits (#68)
Astro-Han 8bbe5fa
ci: lint PR commit messages against Conventional Commits (#69)
Astro-Han fd00a23
ci: stop dependency-review from commenting on every PR
Astro-Han 09dd83f
chore: add $schema to .commitlintrc.json
Astro-Han File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| { | ||
| "$schema": "https://json.schemastore.org/commitlintrc.json", | ||
| "extends": ["@commitlint/config-conventional"] | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| # Advisory check: lint commit messages on the PR against Conventional | ||
| # Commits. Pairs with pr-title-lint.yml -- catches intermediate commits | ||
| # that the PR title check cannot see. Not required in the `dev` | ||
| # ruleset. (#69) | ||
| name: commit-lint | ||
|
|
||
| on: | ||
| pull_request: | ||
| branches: [dev] | ||
|
|
||
| concurrency: | ||
| group: commit-lint-${{ github.event.pull_request.number }} | ||
| cancel-in-progress: true | ||
|
|
||
| permissions: | ||
| contents: read | ||
| pull-requests: read | ||
|
|
||
| jobs: | ||
| lint-commits: | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 3 | ||
| steps: | ||
| - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # actions/checkout@v6 | ||
| with: | ||
| fetch-depth: 0 | ||
| persist-credentials: false | ||
|
|
||
| - uses: wagoid/commitlint-github-action@6cf16efdf4da5277c791d335142c03a0bdf1766e # wagoid/commitlint-github-action@v6.2.1 | ||
| with: | ||
| configFile: .commitlintrc.json |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| # Advisory check: lint PR titles against Conventional Commits. Catches | ||
| # drift early so PR titles read consistently in listings and serve as a | ||
| # well-formed subject when a PR is squash-merged (this repo normally | ||
| # uses merge commits, so the PR title is not the commit subject on | ||
| # `dev`, but the convention still matters for review hygiene). Not | ||
| # required in the `dev` ruleset -- failures flag the PR but do not | ||
| # block merge. Draft PRs with `WIP:` prefix are skipped. (#68) | ||
| name: pr-title-lint | ||
|
|
||
| on: | ||
| pull_request_target: | ||
| types: [opened, edited, reopened, ready_for_review] | ||
| branches: [dev] | ||
|
|
||
| concurrency: | ||
| group: pr-title-lint-${{ github.event.pull_request.number }} | ||
| cancel-in-progress: true | ||
|
|
||
| permissions: | ||
| contents: read | ||
| pull-requests: read | ||
|
|
||
| jobs: | ||
| lint-pr-title: | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 3 | ||
| steps: | ||
| - uses: amannn/action-semantic-pull-request@48f256284bd46cdaab1048c3721360e808335d50 # amannn/action-semantic-pull-request@v6.1.1 | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| with: | ||
| types: | | ||
| feat | ||
| fix | ||
| refactor | ||
| docs | ||
| chore | ||
| ci | ||
| build | ||
| perf | ||
| test | ||
| style | ||
| revert | ||
| requireScope: false | ||
| subjectPattern: ^\S.{2,}$ | ||
| subjectPatternError: | | ||
| The subject after `type:` must be at least 3 characters and start with a non-space character. | ||
| wip: true |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.