Skip to content

refactor(opencode): default it.live tests to platform-aware timeout #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Astro-Han merged 1 commit into from
May 15, 2026
Merged

refactor(opencode): default it.live tests to platform-aware timeout #656

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 18 additions & 17 deletions packages/opencode/test/session/prompt-effect.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,10 +270,25 @@ function makeHttp(httpLayer: Layer.Layer<HttpClient.HttpClient> = FetchHttpClien
).pipe(Layer.provide(summary))
}

const it = testEffect(makeHttp())
const itWithExaQuota = testEffect(makeHttp(httpWithExaQuotaFixture))
// Windows runner is consistently slow on Effect-fiber + SQLite + tmpdir-server
// setup; default the live() timeout instead of bandaging individual tests.
// An explicit third-arg timeout still overrides.
const defaultLiveTimeout = process.platform === "win32" ? 10_000 : 3_000

function withDefaultLiveTimeout<
T extends { live: ((...args: any[]) => any) & { only: any; skip: any } },
>(raw: T): T {
const wrap = (fn: (...args: any[]) => any) =>
(name: any, body: any, opts?: any) => fn(name, body, opts ?? defaultLiveTimeout)
const live = wrap(raw.live) as T["live"]
live.only = wrap(raw.live.only)
live.skip = wrap(raw.live.skip)
return { ...raw, live }
}
Comment thread
Astro-Han marked this conversation as resolved.

const it = withDefaultLiveTimeout(testEffect(makeHttp()))
const itWithExaQuota = withDefaultLiveTimeout(testEffect(makeHttp(httpWithExaQuotaFixture)))
const unix = process.platform !== "win32" ? it.live : it.live.skip
const slowIOTimeout = process.platform === "win32" ? 10_000 : 3_000

// Config that registers a custom "test" provider with a "test-model" model
// so provider model lookup succeeds inside the loop.
Expand Down Expand Up @@ -1294,7 +1309,6 @@ it.live(
}),
{ git: true, config: providerCfg },
),
slowIOTimeout,
)

// Cancel semantics
Expand Down Expand Up @@ -1324,7 +1338,6 @@ it.live(
}),
{ git: true, config: providerCfg },
),
slowIOTimeout,
)

it.live(
Expand Down Expand Up @@ -1352,7 +1365,6 @@ it.live(
}),
{ git: true, config: providerCfg },
),
3_000,
)

it.live(
Expand Down Expand Up @@ -1395,7 +1407,6 @@ it.live(
}),
{ git: true, config: providerCfg },
),
3_000,
)

it.live(
Expand Down Expand Up @@ -1486,7 +1497,6 @@ it.live(
}),
{ git: true, config: providerCfg },
),
3_000,
)

it.live(
Expand Down Expand Up @@ -1564,7 +1574,6 @@ it.live(
}),
{ git: true, config: providerCfg },
),
3_000,
)

// Queue semantics
Expand Down Expand Up @@ -1608,7 +1617,6 @@ it.live(
}),
{ git: true, config: providerCfg },
),
slowIOTimeout,
)

it.live(
Expand Down Expand Up @@ -1677,7 +1685,6 @@ it.live(
}),
{ git: true, config: providerCfg },
),
slowIOTimeout,
)

it.live(
Expand Down Expand Up @@ -1707,7 +1714,6 @@ it.live(
}),
{ git: true, config: providerCfg },
),
slowIOTimeout,
)

it.live("assertNotBusy succeeds when idle", () =>
Expand Down Expand Up @@ -1752,7 +1758,6 @@ it.live(
}),
{ git: true, config: providerCfg },
),
3_000,
)

unix("shell captures stdout and stderr in completed tool output", () =>
Expand Down Expand Up @@ -2036,8 +2041,6 @@ unix(
30_000,
)

const shellQueueTimeout = process.platform === "win32" ? 10_000 : 3_000

unix(
"loop waits while shell runs and starts after shell exits",
() =>
Expand Down Expand Up @@ -2073,7 +2076,6 @@ unix(
}),
{ git: true, config: providerCfg },
),
shellQueueTimeout,
)

unix(
Expand Down Expand Up @@ -2113,7 +2115,6 @@ unix(
}),
{ git: true, config: providerCfg },
),
shellQueueTimeout,
)

unix(
Expand Down
Loading