Skip to content

fix: tolerate Windows NSIS line endings #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Astro-Han merged 3 commits into from
May 9, 2026
Merged

fix: tolerate Windows NSIS line endings #509

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9469ce1
fix: tolerate Windows NSIS line endings
Astro-Han May 9, 2026
b3f1224
fix: relax NSIS installer test whitespace
Astro-Han May 9, 2026
45311c6
fix: preserve NSIS declaration line boundary
Astro-Han May 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/desktop-electron/electron-builder-nsis-shortcut.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ describe("windows nsis desktop shortcut customization", () => {

test("declares a real custom page instead of running page commands inline", () => {
expect(script).toContain("!ifndef BUILD_UNINSTALLER")
expect(script).toContain("!ifndef BUILD_UNINSTALLER\n Var AddDesktopShortcutCheckbox")
expect(script).toMatch(/!ifndef BUILD_UNINSTALLER\r?\n[^\S\r\n]*Var AddDesktopShortcutCheckbox/)
expect(script).toContain("PageEx custom")
expect(script).toContain('Caption "$(PawWorkShortcutOptions)"')
expect(script).toContain("PageCallbacks PawWorkDesktopShortcutPageCreate PawWorkDesktopShortcutPageLeave")
Expand Down
Loading