fix(app): simplify titlebar worktree badge - #390
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughPawworkWorktreeBadge replaces title-attribute hover text with a Tooltip wrapper, adds a WorktreeTooltipRow helper, chooses label via ChangesWorktree Badge Tooltip Upgrade
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Review rate limit: 8/10 reviews remaining, refill in 10 minutes and 6 seconds. Comment |
There was a problem hiding this comment.
Code Review
This pull request replaces the native title attribute on the PawworkWorktreeBadge with a custom Tooltip component, providing a structured view of worktree details like name, branch, and location. It also increases the badge's maximum width and updates the test suite. Feedback suggests using the direct worktree name in the tooltip to avoid redundancy and adding layout classes to the tooltip trigger to ensure proper shrinking in the titlebar.
Summary
Why
The titlebar previously combined worktree name and branch in one badge, which repeated information and caused long names to truncate too early. The badge now keeps the titlebar scannable while the tooltip carries the full context.
Related Issue
No linked issue. Reported from local product review.
Human Review Status
Pending. A human should make the final merge decision after reviewing the final diff and verification evidence.
Review Focus
Risk Notes
Low. This is a small titlebar UI change with no data, permissions, desktop shell, packaging, updater, signing, or migration impact.
How To Verify
Screenshots or Recordings
Not captured in this session. Visible change is covered by focused component tests; manual UI review is still recommended before merge.
Checklist
dev, and my PR title and commit messages use Conventional Commits in EnglishSummary by CodeRabbit
New Features
Improvements
Tests