-
Notifications
You must be signed in to change notification settings - Fork 14
fix: default review to last turn #338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
c091c33
fix: split git staged diff helpers
Astro-Han eb542bc
fix: expose staged review diff mode
Astro-Han 10773a1
fix: define review change modes
Astro-Han a31312a
fix: default review to last turn
Astro-Han 536a8c1
fix: use effect harness for git tests
Astro-Han 2a142ba
fix: use scoped git test fixture
Astro-Han ba110bf
fix: strengthen git head diff test
Astro-Han File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| import { describe, expect, test } from "bun:test" | ||
| import { | ||
| coerceReviewChangeMode, | ||
| DEFAULT_REVIEW_CHANGE_MODE, | ||
| isVcsReviewMode, | ||
| nextReviewModeForSessionChange, | ||
| reviewChangeOptions, | ||
| reviewDiffsForMode, | ||
| reviewModeLabelKey, | ||
| } from "./review-change-mode" | ||
|
|
||
| describe("review change mode", () => { | ||
| test("defaults to last turn", () => { | ||
| expect(DEFAULT_REVIEW_CHANGE_MODE).toBe("turn") | ||
| }) | ||
|
|
||
| test("keeps all review modes selectable for git projects", () => { | ||
| expect(reviewChangeOptions({ isGit: true })).toEqual(["unstaged", "staged", "branch", "turn"]) | ||
| }) | ||
|
|
||
| test("keeps branch selectable even when the branch diff is empty", () => { | ||
| expect(reviewChangeOptions({ isGit: true })).toContain("branch") | ||
| }) | ||
|
|
||
| test("limits non-git projects to last turn", () => { | ||
| expect(reviewChangeOptions({ isGit: false })).toEqual(["turn"]) | ||
| }) | ||
|
|
||
| test("falls back to last turn when the selected mode is unavailable", () => { | ||
| expect(coerceReviewChangeMode("branch", ["turn"])).toBe("turn") | ||
| }) | ||
|
|
||
| test("identifies VCS-backed review modes", () => { | ||
| expect(isVcsReviewMode("unstaged")).toBe(true) | ||
| expect(isVcsReviewMode("staged")).toBe(true) | ||
| expect(isVcsReviewMode("branch")).toBe(true) | ||
| expect(isVcsReviewMode("turn")).toBe(false) | ||
| }) | ||
|
|
||
| test("maps modes to translation keys", () => { | ||
| expect(reviewModeLabelKey("unstaged")).toBe("ui.sessionReview.title.unstaged") | ||
| expect(reviewModeLabelKey("staged")).toBe("ui.sessionReview.title.staged") | ||
| expect(reviewModeLabelKey("branch")).toBe("ui.sessionReview.title.branch") | ||
| expect(reviewModeLabelKey("turn")).toBe("ui.sessionReview.title.lastTurn") | ||
| }) | ||
|
|
||
| test("resets session changes to last turn", () => { | ||
| expect(nextReviewModeForSessionChange()).toBe("turn") | ||
| }) | ||
|
|
||
| test("uses turn diffs without falling back to VCS diffs", () => { | ||
| const turn = ["turn diff"] | ||
| const vcs = { | ||
| unstaged: ["unstaged diff"], | ||
| staged: ["staged diff"], | ||
| branch: ["branch diff"], | ||
| } | ||
|
|
||
| expect(reviewDiffsForMode("turn", { turn, vcs })).toEqual(turn) | ||
| }) | ||
|
|
||
| test("keeps an empty last turn empty when VCS diffs exist", () => { | ||
| const vcs = { | ||
| unstaged: ["unstaged diff"], | ||
| staged: ["staged diff"], | ||
| branch: ["branch diff"], | ||
| } | ||
|
|
||
| expect(reviewDiffsForMode("turn", { turn: [], vcs })).toEqual([]) | ||
| }) | ||
| }) |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.