fix: improve feedback problem report upload flow

packages/desktop-electron/src/main/feedback.test.ts

@@ -21,22 +21,51 @@ function setup(overrides: Partial<Parameters<typeof createFeedbackHandler>[0]> =
   const calls = {
     copied: "",
     opened: "",
+    fallbackUrl: "",
+    shown: "",
+    openedPath: "",
+    savedMarkdown: "",
     errors: [] as unknown[],
+    handledErrors: [] as string[],
   }
   return {
     calls,
     handler: createFeedbackHandler({
       feedbackUrl: "https://example.com/form",
+      reportRoot: "/tmp/pawwork/problem-reports",
+      context: () => "active",
       confirm: async () => true,
       copy: async (value) => {
         calls.copied = value
       },
       openExternal: async (url) => {
         calls.opened = url
       },
+      showFeedbackUrlFallback: async (url) => {
+        calls.fallbackUrl = url
+      },
+      showItemInFolder: async (path) => {
+        calls.shown = path
+      },
+      openPath: async (path) => {
+        calls.openedPath = path
+      },
+      saveReport: async ({ markdown, reportId }) => {
+        calls.savedMarkdown = markdown
+        return {
+          path: `/tmp/pawwork/problem-reports/pawwork-problem-report-${reportId}.md`,
+          fileName: `pawwork-problem-report-${reportId}.md`,
+          locationHint: `PawWork app data/.../problem-reports/pawwork-problem-report-${reportId}.md`,
+        }
+      },
+      cleanupReports: async () => undefined,
+      sessionExportTimeoutMs: 10,
       diagnostics: () => diagnostics,
-      logTail: () => "log tail",
+      logTail: () => "log tail\n[error] launch failed",
       sessionExport: async () => ({ status: "none" }),
+      onHandledError: (message) => {
+        calls.handledErrors.push(message)
+      },
       onError: (error) => {
         calls.errors.push(error)
       },
@@ -47,19 +76,25 @@ function setup(overrides: Partial<Parameters<typeof createFeedbackHandler>[0]> =
 
 describe("feedback handler", () => {
   test("has localized confirmation labels for Simplified Chinese", () => {
-    expect(feedbackDialogLabels("zh").title).toBe("复制问题报告？")
-    expect(feedbackDialogLabels("zh").confirm).toBe("复制报告并打开表单")
+    expect(feedbackDialogLabels("zh").title).toBe("准备问题报告？")
+    expect(feedbackDialogLabels("zh").confirm).toBe("复制摘要并打开表单")
+    expect(feedbackDialogLabels("zh").message).toContain("简短摘要")
+    expect(feedbackDialogLabels("zh").message).toContain("完整问题报告文件")
+    expect(feedbackDialogLabels("zh").message).toContain("提交后可以删除")
   })
 
   test("has English confirmation labels", () => {
-    expect(feedbackDialogLabels("en").title).toBe("Copy problem report?")
-    expect(feedbackDialogLabels("en").confirm).toBe("Copy report and open form")
+    expect(feedbackDialogLabels("en").title).toBe("Prepare problem report?")
+    expect(feedbackDialogLabels("en").confirm).toBe("Copy summary and open form")
+    expect(feedbackDialogLabels("en").message).toContain("short summary")
+    expect(feedbackDialogLabels("en").message).toContain("full problem report file")
+    expect(feedbackDialogLabels("en").message).toContain("delete the local full report file after submission")
     expect(feedbackDialogLabels("en").failedTitle).toBe("Problem Report Failed")
   })
 
   test("falls back to English confirmation labels", () => {
-    expect(feedbackDialogLabels("fr" as never).title).toBe("Copy problem report?")
-    expect(feedbackDialogLabels("fr" as never).confirm).toBe("Copy report and open form")
+    expect(feedbackDialogLabels("fr" as never).title).toBe("Prepare problem report?")
+    expect(feedbackDialogLabels("fr" as never).confirm).toBe("Copy summary and open form")
   })
 
   test("cancel does not copy or open", async () => {
@@ -69,14 +104,42 @@ describe("feedback handler", () => {
     expect(subject.calls.opened).toBe("")
   })
 
-  test("confirm copies report and opens form", async () => {
+  test("confirm copies a short summary, saves the full report, reveals the file, and opens form", async () => {
     const subject = setup()
     await subject.handler()
-    expect(subject.calls.copied).toContain("PawWork Problem Report")
+    expect(subject.calls.copied).toContain("PawWork Problem Report Summary")
+    expect(subject.calls.copied).toContain("Full report: ready for manual upload")
+    expect(subject.calls.copied).not.toContain("```json")
+    expect(subject.calls.savedMarkdown).toContain("# PawWork Problem Report")
+    expect(subject.calls.shown).toContain("/tmp/pawwork/problem-reports/")
     expect(subject.calls.opened).toBe("https://example.com/form")
   })
 
-  test("uses the context captured before confirmation", async () => {
+  test("busy guard starts before confirmation and releases on cancel", async () => {
+    let confirms = 0
+    let resolveConfirm: (value: boolean) => void = () => undefined
+    const firstConfirm = new Promise<boolean>((resolve) => {
+      resolveConfirm = resolve
+    })
+    const subject = setup({
+      confirm: async () => {
+        confirms += 1
+        return firstConfirm
+      },
+    })
+
+    const first = subject.handler()
+    const second = subject.handler()
+    resolveConfirm(false)
+    await Promise.all([first, second])
+
+    expect(confirms).toBe(1)
+    expect(subject.calls.copied).toBe("")
+    await subject.handler()
+    expect(confirms).toBe(2)
+  })
+
+  test("uses the context snapshotted before confirmation changes focus", async () => {
     let current = "active"
     let exportedContext: unknown
     let diagnosticsContext: unknown
@@ -109,8 +172,126 @@ describe("feedback handler", () => {
       },
     })
     await subject.handler()
-    expect(subject.calls.copied).toContain('"status": "failed"')
+    expect(subject.calls.savedMarkdown).toContain('"status": "failed"')
+    expect(subject.calls.savedMarkdown).toContain("session unavailable")
+    expect(subject.calls.copied).toContain("PawWork Problem Report Summary")
+    expect(subject.calls.opened).toBe("https://example.com/form")
+  })
+
+  test("slow session export times out and still produces report artifacts", async () => {
+    let aborted = false
+    const subject = setup({
+      sessionExportTimeoutMs: 1,
+      sessionExport: async (_context, signal) =>
+        new Promise(() => {
+          signal?.addEventListener("abort", () => {
+            aborted = true
+          })
+        }),
+    })
+
+    await subject.handler()
+
+    expect(aborted).toBe(true)
+    expect(subject.calls.copied).toContain("PawWork Problem Report Summary")
+    expect(subject.calls.savedMarkdown).toContain('"status": "failed"')
+    expect(subject.calls.savedMarkdown).toContain("session export timed out")
+    expect(subject.calls.opened).toBe("https://example.com/form")
+  })
+
+  test("file write failure still copies summary and opens form without attachment instructions", async () => {
+    const subject = setup({
+      saveReport: async () => {
+        throw new Error("EACCES: /Users/name/problem-reports")
+      },
+    })
+
+    await subject.handler()
+
+    expect(subject.calls.copied).toContain("Full report: not generated")
+    expect(subject.calls.copied).toContain("Submit this summary without an attachment if needed.")
+    expect(subject.calls.copied).not.toContain("/Users/name")
+    expect(subject.calls.shown).toBe("")
+    expect(subject.calls.opened).toBe("https://example.com/form")
+  })
+
+  test("full report construction failure still copies a minimum summary and opens form", async () => {
+    const subject = setup({
+      diagnostics: () => {
+        throw new Error("diagnostics exploded")
+      },
+    })
+
+    await subject.handler()
+
+    expect(subject.calls.copied).toContain("PawWork Problem Report Summary")
+    expect(subject.calls.copied).toContain("Full report: not generated")
+    expect(subject.calls.opened).toBe("https://example.com/form")
+  })
+
+  test("form open failure is reported after summary and report file are available", async () => {
+    const subject = setup({
+      openExternal: async () => {
+        throw new Error("browser unavailable")
+      },
+    })
+
+    await subject.handler()
+
+    expect(subject.calls.copied).toContain("PawWork Problem Report Summary")
+    expect(subject.calls.savedMarkdown).toContain("# PawWork Problem Report")
+    expect(subject.calls.fallbackUrl).toBe("https://example.com/form")
+    expect(subject.calls.handledErrors).toContain("feedback form open failed")
+    expect(subject.calls.errors).toHaveLength(0)
+  })
+
+  test("file reveal failure still opens the form and keeps summary recovery information", async () => {
+    const subject = setup({
+      showItemInFolder: async () => {
+        throw new Error("reveal failed")
+      },
+    })
+
+    await subject.handler()
+
+    expect(subject.calls.copied).toContain("problem-reports")
+    expect(subject.calls.openedPath).toBe("/tmp/pawwork/problem-reports")
+    expect(subject.calls.opened).toBe("https://example.com/form")
+    expect(subject.calls.handledErrors).toContain("problem report reveal failed")
+  })
+
+  test("directory open fallback reports Electron openPath error strings", async () => {
+    const subject = setup({
+      showItemInFolder: async () => {
+        throw new Error("reveal failed")
+      },
+      openPath: async (path) => {
+        subject.calls.openedPath = path
+        return "No application is associated with the specified file"
+      },
+    })
+
+    await subject.handler()
+
+    expect(subject.calls.openedPath).toBe("/tmp/pawwork/problem-reports")
+    expect(subject.calls.opened).toBe("https://example.com/form")
+    expect(subject.calls.handledErrors).toContain("problem report directory open failed")
+  })
+
+  test("cleanup failure does not block opening the form", async () => {
+    const subject = setup({
+      cleanupReports: async () => {
+        throw new Error("cleanup failed")
+      },
+    })
+
+    await subject.handler()
+
+    expect(subject.calls.copied).toContain("PawWork Problem Report Summary")
+    expect(subject.calls.shown).toContain("/tmp/pawwork/problem-reports/")
     expect(subject.calls.opened).toBe("https://example.com/form")
+    expect(subject.calls.errors).toHaveLength(0)
+    expect(subject.calls.handledErrors).toContain("problem report cleanup failed")
   })
 
   test("missing feedback URL does not copy or open", async () => {