fix(app): require app update notice section - #153
Conversation
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 10 minutes and 44 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (7)
📝 WalkthroughWalkthroughThis PR implements a fix for a bug where post-update modals displayed raw Markdown download links by introducing a dedicated "## App Update Notice" section in GitHub releases. The app's release notes parser now extracts content exclusively from this section, preventing fallback to generic release body content. Version bumps to 0.2.6 across all workspace packages and release checklist documentation is updated accordingly. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Code Review
This pull request updates the project version to 0.2.6 across multiple packages and introduces logic to extract a specific 'App Update Notice' section from GitHub release bodies. The changes include updates to the release checklist, package manifests, and the implementation of a section-finding utility with associated unit tests. A review comment identifies a potential issue with the regex used to detect markdown headings, recommending a more inclusive pattern to ensure the parser correctly identifies section boundaries even when headings are empty or contain only whitespace.
240c432 to
e8aba7a
Compare
Summary
Require GitHub Release bodies to provide a dedicated
## App Update Noticesection before the in-app post-update modal shows release text. Bump release package versions to0.2.6.Why
Fixes #124. The previous parser picked the first non-heading line from the general GitHub Release body, so a Downloads link could appear as the user-facing update notice. The app now avoids guessing from Downloads, Highlights, Verification, or maintenance sections.
Related Issue
Fixes #124
How To Verify
bun --cwd packages/app test src/context/highlights.test.ts bun --cwd packages/app typecheck bun install --frozen-lockfileAlso ran fresh-eyes code review with no Critical, Important, or worth-fixing Minor findings.
Screenshots or Recordings
Not included. This changes release-note parsing behavior and release metadata, with no visible UI layout change in this branch.
Checklist
dev, and my PR title and commit messages use Conventional Commits in EnglishSummary by CodeRabbit