ci: split Windows server tools advisory shard - #1389
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe Windows advisory workflow splits the opencode test matrix into seven shards by extracting ChangesWindows opencode shard split and per-attempt timeout
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install failed. For unrecoverable errors, disable the tool in CodeRabbit configuration. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Suggested priority: P3 (only low-risk paths changed (.github/workflows/windows-advisory.yml, packages/opencode/test/github/ci-workflow.test.ts)).
P1/P0 are reserved for maintainer confirmation. Please relabel manually if this is a release blocker, security issue, data-loss risk, or updater/runtime failure.
Summary
Split the Windows advisory
opencode-server-toolsshard into smaller server-derived shards and add process-level attempt timeouts for the shards that previously could hang until the job timeout cancelled the run.Why
The latest
devpush for #1387 cancelledwindows-advisoryrun 27802484637 becauseunit-windows-opencode-server-toolsjob 82275434554 reached its job timeout whilebun testwas still running. The log showed no assertion failure: setup succeeded, other Windows shards passed, and the unit process stopped producing output aftertest/browser/session.test.tsbefore GitHub cancelled the operation.This PR keeps the Windows advisory coverage but prevents one broad shard or one hung Bun process from consuming the entire job budget before the retry wrapper can observe an exit code. It unblocks #1387 post-merge closeout and future #936 migration closeout.
Related Issue
Related to #936.
Human Review Status
Pending
Review Focus
Please check that the new shard boundaries preserve all existing opencode Windows advisory test coverage exactly once, and that the per-attempt timeout budget is large enough for normal runs while still firing before the job-level timeout.
Risk Notes
Windows-only runtime behavior cannot be fully proven on this macOS worktree; the PR CI Windows advisory jobs are the authoritative verification. No UI, copy, docs, dependency, credential, deletion, release, or generated-content surface changed.
How To Verify
Screenshots or Recordings
Not applicable. No visible UI changes.
Checklist
bug,enhancement,task,documentation. Type labels are author-added; the labeler bot does NOT assign them. Add the label in the GitHub UI, then tick this.app,ui,platform,harness,ci. The labeler bot assigns these on PR open based on changed paths. Confirm the bot's choice (or override if wrong), then tick this.P0,P1,P2,P3. The priority-triage bot suggests one on PR open. Confirm or override, then tick this.Pending,Approved by @<reviewer>, orNot required: <reason>(default isPending; "not required" is restricted to bot-authored low-risk PRs).dev, and my PR title and commit messages use Conventional Commits in English.Summary by CodeRabbit
Chores
Tests