Repository navigation
fix: upgrade Electron for Node 24.16+/26 install compatibility #1352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
46a923f
fix: replace Node version guard with yauzl override for Electron comp…
Astro-Han 85e59da
fix: pin yauzl to exact version for override consistency
Astro-Han 4699a4f
fix: remove Node version guard, update lockfile for yauzl override
Astro-Han 875cb10
ci: assert Electron install complete before repair step
Astro-Han c35cdea
ci: tighten Electron pre-repair assertion using repair script's isEle…
Astro-Han 6e9b978
ci: also check path.txt content in Electron pre-repair assertion
Astro-Han 1409de0
fix: upgrade Electron to 40.10.3, add --assert-complete and CI instal…
Astro-Han File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,34 +1,7 @@ | ||
| const unsupportedMajor = 25 | ||
| const version = process.version | ||
| const match = /^v?(\d+)(?:\.|$)/.exec(version) | ||
|
|
||
| let errorMessage = "" | ||
|
|
||
| if (!match) { | ||
| errorMessage = `Unsupported Node version format: ${version}. Use Node 24 for PawWork dependency installs.` | ||
| } | ||
|
|
||
| if (match && Number(match[1]) >= unsupportedMajor) { | ||
| errorMessage = [ | ||
| "Use Node 24 for PawWork dependency installs.", | ||
| "", | ||
| `Current node: ${version}`, | ||
| "", | ||
| "Node 25+ can make Electron 40.8.0 postinstall leave an incomplete Electron.app while reporting success.", | ||
| "Switch to Node 24 (see .node-version), delete node_modules, then reinstall dependencies.", | ||
| "", | ||
| "macOS/Linux:", | ||
| " rm -rf node_modules", | ||
| "", | ||
| "PowerShell:", | ||
| " Remove-Item -Recurse -Force node_modules", | ||
| "", | ||
| "Then reinstall:", | ||
| " bun install --frozen-lockfile", | ||
| ].join("\n") | ||
| } | ||
|
|
||
| if (errorMessage) { | ||
| console.error(errorMessage) | ||
| console.error(`Unsupported Node version format: ${version}.`) | ||
| process.exit(1) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.