-
Notifications
You must be signed in to change notification settings - Fork 14
fix: guard dependency installs on unsupported Node versions #1346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
2b692d6
fix: guard dependency installs on unsupported Node versions
Astro-Han eaa02b6
fix: harden Node install guard follow-up
Astro-Han b67c66d
fix: run Node install guard in preinstall
Astro-Han 6ecf1dc
fix: simplify Node install guard script
Astro-Han File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| 24 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| const unsupportedMajor = 25 | ||
| const version = process.version | ||
| const match = /^v?(\d+)(?:\.|$)/.exec(version) | ||
|
|
||
| let errorMessage = "" | ||
|
|
||
| if (!match) { | ||
| errorMessage = `Unsupported Node version format: ${version}. Use Node 24 for PawWork dependency installs.` | ||
| } | ||
|
|
||
| if (match && Number(match[1]) >= unsupportedMajor) { | ||
| errorMessage = [ | ||
| "Use Node 24 for PawWork dependency installs.", | ||
| "", | ||
| `Current node: ${version}`, | ||
| "", | ||
| "Node 25+ can make Electron 40.8.0 postinstall leave an incomplete Electron.app while reporting success.", | ||
| "Switch to Node 24 (see .node-version), delete node_modules, then reinstall dependencies.", | ||
| "", | ||
| "macOS/Linux:", | ||
| " rm -rf node_modules", | ||
| "", | ||
| "PowerShell:", | ||
| " Remove-Item -Recurse -Force node_modules", | ||
| "", | ||
| "Then reinstall:", | ||
| " bun install --frozen-lockfile", | ||
| ].join("\n") | ||
| } | ||
|
|
||
| if (errorMessage) { | ||
| console.error(errorMessage) | ||
| process.exit(1) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| import { expect, test } from "bun:test" | ||
| import { spawnSync } from "node:child_process" | ||
|
|
||
| function runGuard(version) { | ||
| return spawnSync( | ||
| "node", | ||
| [ | ||
| "--input-type=module", | ||
| "-e", | ||
| [ | ||
| `Object.defineProperty(process, "version", { value: ${JSON.stringify(version)} })`, | ||
| `await import("./check-node.mjs")`, | ||
| ].join(";"), | ||
| ], | ||
| { | ||
| cwd: import.meta.dirname, | ||
| encoding: "utf8", | ||
| }, | ||
| ) | ||
| } | ||
|
|
||
| test("rejects Node 25+ with reinstall guidance", () => { | ||
| const result = runGuard("v25.0.0") | ||
|
|
||
| expect(result.status).toBe(1) | ||
| expect(result.stderr).toContain("Current node: v25.0.0") | ||
| expect(result.stderr).toContain("Node 24") | ||
| expect(result.stderr).toContain(".node-version") | ||
| expect(result.stderr).toContain("delete node_modules") | ||
| expect(result.stderr).toContain("rm -rf node_modules") | ||
| expect(result.stderr).toContain("Remove-Item -Recurse -Force node_modules") | ||
| expect(result.stderr).toContain("bun install --frozen-lockfile") | ||
| }) | ||
|
|
||
| test("allows Node 24", () => { | ||
| const result = runGuard("v24.14.0") | ||
|
|
||
| expect(result.status).toBe(0) | ||
| expect(result.stderr).toBe("") | ||
| }) | ||
|
|
||
| test("rejects unparseable Node versions with a clean message", () => { | ||
| const result = runGuard("invalid-version") | ||
|
|
||
| expect(result.status).toBe(1) | ||
| expect(result.stderr).toContain("Unsupported Node version format: invalid-version") | ||
| }) | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.