Skip to content

test(opencode): relax prompt cancel race timeout #1276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Astro-Han merged 1 commit into from
Jun 12, 2026
Merged

test(opencode): relax prompt cancel race timeout #1276

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions packages/opencode/test/session/prompt-effect.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,8 @@ function defer<T>() {
return { promise, resolve }
}

const cancelRaceCheckpointTimeout = "5 seconds"

type Mutable<T> = { -readonly [K in keyof T]: T[K] }

function withSh<A, E, R>(fx: () => Effect.Effect<A, E, R>) {
Expand Down Expand Up @@ -1801,11 +1803,14 @@ it.live(
yield* Effect.addFinalizer(() => Effect.sync(() => void (mutableSessions.updateMessage = originalUpdateMessage)))

const fiber = yield* prompt.loop({ sessionID: chat.id }).pipe(Effect.forkChild)
const startedExit = yield* Effect.promise(() => started.promise).pipe(Effect.timeout("1 second"), Effect.exit)
const startedExit = yield* Effect.promise(() => started.promise).pipe(
Effect.timeout(cancelRaceCheckpointTimeout),
Effect.exit,
)
expect(Exit.isSuccess(startedExit)).toBe(true)
const cancelExit = yield* prompt.cancel(chat.id).pipe(Effect.timeout("1 second"), Effect.exit)
const cancelExit = yield* prompt.cancel(chat.id).pipe(Effect.timeout(cancelRaceCheckpointTimeout), Effect.exit)
expect(Exit.isSuccess(cancelExit)).toBe(true)
const exit = yield* Fiber.await(fiber).pipe(Effect.timeout("1 second"))
const exit = yield* Fiber.await(fiber).pipe(Effect.timeout(cancelRaceCheckpointTimeout))
expect(Exit.isSuccess(exit)).toBe(true)

const messages = yield* sessions.messages({ sessionID: chat.id })
Expand Down Expand Up @@ -1855,11 +1860,14 @@ it.live(
yield* Effect.addFinalizer(() => Effect.sync(() => void (mutablePlugin.trigger = originalTrigger)))

const fiber = yield* prompt.loop({ sessionID: chat.id }).pipe(Effect.forkChild)
const startedExit = yield* Effect.promise(() => started.promise).pipe(Effect.timeout("1 second"), Effect.exit)
const startedExit = yield* Effect.promise(() => started.promise).pipe(
Effect.timeout(cancelRaceCheckpointTimeout),
Effect.exit,
)
expect(Exit.isSuccess(startedExit)).toBe(true)
const cancelExit = yield* prompt.cancel(chat.id).pipe(Effect.timeout("1 second"), Effect.exit)
const cancelExit = yield* prompt.cancel(chat.id).pipe(Effect.timeout(cancelRaceCheckpointTimeout), Effect.exit)
expect(Exit.isSuccess(cancelExit)).toBe(true)
const exit = yield* Fiber.await(fiber).pipe(Effect.timeout("1 second"))
const exit = yield* Fiber.await(fiber).pipe(Effect.timeout(cancelRaceCheckpointTimeout))
expect(Exit.isSuccess(exit)).toBe(true)

const messages = yield* sessions.messages({ sessionID: chat.id })
Expand Down
Loading