Skip to content

ci(labeler): route packages/core changes to the harness label - #1168

Merged
Astro-Han merged 1 commit into
devfrom
claude/labeler-core-routing
Jun 4, 2026
Merged

ci(labeler): route packages/core changes to the harness label#1168
Astro-Han merged 1 commit into
devfrom
claude/labeler-core-routing

Conversation

@Astro-Han

@Astro-Han Astro-Han commented Jun 4, 2026

Copy link
Copy Markdown
Owner

Summary

packages/core/** had no rule in .github/labeler.yml, so any PR touching only packages/core could not satisfy the label policy: pr-triage runs actions/labeler with sync-labels: true (which strips any routing label not backed by a path glob), and .github/scripts/label-policy-check.js then requires at least one routing label (app/ui/platform/harness/ci). The result was a structural deadlock — the labeler removed any manually added routing label, and pr-triage failed every time.

Map packages/core/** to harness, alongside the existing packages/opencode/** and packages/sdk/** rules (core is the engine the opencode harness builds on).

Why

Without this, every packages/core-only PR is un-mergeable under the label policy. This surfaced on #1167 (a core/util/log.ts fix). The fix is one glob and unblocks all future core-only PRs.

Related Issue

None — discovered while landing #1167.

Human Review Status

Pending

Review Focus

That harness is the right routing bucket for packages/core (it backs the opencode CLI/runtime, not the desktop app/ui/electron/ci surfaces).

Risk Notes

Minimal. CI label-routing config only; no product code, no build/test behavior. Worst case is a mis-routed label, fixable by editing one line.

How To Verify

After merge, re-trigger pr-triage on a packages/core-only PR (e.g. #1167):
the labeler assigns `harness` from the new packages/core/** glob, and the label
policy (one type + one priority + one routing) passes.

Screenshots or Recordings

N/A — CI config only.

Checklist

  • Type label — exactly one of bug, enhancement, task, documentation (task).
  • Routing labelsci is auto-assigned by the labeler (this PR touches .github/**).
  • Priority label — auto-suggested by the triage bot.
  • Human Review Status: Pending.
  • I linked the related issue, or stated in Summary why there is no issue.
  • I described the review focus and any meaningful risks.
  • I replaced the example block in How To Verify with the real verification steps.
  • I did not introduce unrelated changes beyond the stated scope.
  • I reviewed the final diff.
  • I am targeting dev, and my PR title and commit messages use Conventional Commits in English.

Summary by CodeRabbit

  • Chores
    • Updated GitHub workflow configuration to optimize labeling processes.

The label policy requires every PR to carry a routing label
(app/ui/platform/harness/ci), and pr-triage runs actions/labeler with
sync-labels: true, which strips any routing label not backed by a path glob.
labeler.yml had no rule for packages/core/**, so a PR touching only
packages/core could never satisfy the policy — the labeler removed any
manually added routing label and pr-triage then failed.

Map packages/core/** to harness (the engine the opencode harness builds on),
matching the existing packages/opencode/** and packages/sdk/** rules.
@Astro-Han Astro-Han added the task Narrow execution, audit, spike, migration, tracking, or upstream follow-up work label Jun 4, 2026
@gemini-code-assist

Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@github-actions github-actions Bot added the ci Continuous integration / GitHub Actions label Jun 4, 2026
@coderabbitai

coderabbitai Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 5cc7b991-7760-46a6-9721-62c23c4297fc

📥 Commits

Reviewing files that changed from the base of the PR and between 83204d7 and 88157e3.

📒 Files selected for processing (1)
  • .github/labeler.yml

📝 Walkthrough

Walkthrough

Updated .github/labeler.yml to extend the harness labeler to automatically apply to changes within packages/core/** file paths.

Changes

Harness Labeler Scope

Layer / File(s) Summary
Harness labeler scope update
.github/labeler.yml
Added packages/core/** to the harness labeler's changed-files criteria.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • Astro-Han/pawwork#573: Related .github/labeler.yml changes that define and extend path-based label routing rules for the harness scope.

Suggested labels

ci, harness

Poem

🐰 With whiskers twitching, I organize with glee,
packages/core/** now labeled perfectly!
The harness scope expands, no paths left behind,
Configuration magic, so tidy and refined. 🏷️

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and specifically describes the main change: adding packages/core to the harness label routing in the GitHub labeler configuration.
Description check ✅ Passed The description is comprehensive and covers all required template sections: Summary, Why, Related Issue, Human Review Status, Review Focus, Risk Notes, How To Verify, and a substantially completed Checklist.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/labeler-core-routing

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the P2 Medium priority label Jun 4, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested priority: P2 (includes non-doc, non-test paths outside the low-risk bucket).

P1/P0 are reserved for maintainer confirmation. Please relabel manually if this is a release blocker, security issue, data-loss risk, or updater/runtime failure.

@Astro-Han
Astro-Han merged commit 258eb98 into dev Jun 4, 2026
36 of 37 checks passed
@Astro-Han
Astro-Han deleted the claude/labeler-core-routing branch June 4, 2026 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous integration / GitHub Actions P2 Medium priority task Narrow execution, audit, spike, migration, tracking, or upstream follow-up work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant