Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions packages/opencode/src/server/instance/permission.ts
Original file line number Diff line number Diff line change
Expand Up @@ -79,11 +79,16 @@ export const PermissionRoutes = lazy(() =>
async (c) => {
const params = c.req.valid("param")
const json = c.req.valid("json")
await Permission.reply({
requestID: params.requestID,
reply: json.reply,
message: json.message,
})
await AppRuntime.runPromise(
Effect.gen(function* () {
const permission = yield* Permission.Service
yield* permission.reply({
requestID: params.requestID,
reply: json.reply,
message: json.message,
})
}),
)
return c.json(true)
},
)
Expand Down
57 changes: 57 additions & 0 deletions packages/opencode/test/server/permission-routes.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
import { afterEach, describe, expect, test } from "bun:test"
import { Deferred } from "effect"
import { Hono } from "hono"
import { AppRuntime } from "../../src/effect/app-runtime"
import { Permission } from "../../src/permission"
import { PermissionID } from "../../src/permission/schema"
import { Instance } from "../../src/project/instance"
import { PermissionRoutes } from "../../src/server/instance/permission"
import { SessionID } from "../../src/session/schema"
import { tmpdir } from "../fixture/fixture"

afterEach(async () => {
await Instance.disposeAll()
})

describe("permission routes", () => {
function app() {
return new Hono().route("/permission", PermissionRoutes())
}

test("replies to a pending permission through the route runtime", async () => {
await using tmp = await tmpdir({ git: true })
await Instance.provide({
directory: tmp.path,
fn: async () => {
const requestID = PermissionID.ascending()
const pending = await AppRuntime.runPromise(Deferred.make<void>())
const asked = AppRuntime.runPromise(
Permission.Service.use((permission) =>
permission.ask({
id: requestID,
sessionID: SessionID.descending(),
permission: "bash",
patterns: ["echo ok"],
metadata: {},
always: ["echo ok"],
ruleset: [{ permission: "bash", pattern: "echo ok", action: "ask" }],
onPending: () => Deferred.succeed(pending, undefined),
Comment thread
Astro-Han marked this conversation as resolved.
}),
),
)

await AppRuntime.runPromise(Deferred.await(pending))

const response = await app().request(`/permission/${requestID}/reply`, {
method: "POST",
headers: { "content-type": "application/json" },
body: JSON.stringify({ reply: "once" }),
})

expect(response.status).toBe(200)
expect(await response.json()).toBe(true)
await expect(asked).resolves.toBeUndefined()
},
})
})
})
Loading