Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve housekeeping issue and add 5 watchfaces #46

Merged
merged 15 commits into from
Dec 5, 2021
Merged

Solve housekeeping issue and add 5 watchfaces #46

merged 15 commits into from
Dec 5, 2021

Conversation

eLtMosen
Copy link
Member

@eLtMosen eLtMosen commented Dec 1, 2021

Solve positions from this housekeeping issue
#44

  • Sort all WF alphabetically
  • Update thumbnails
  • Change paths to watchface-img in all WF with images
  • Swap all asteroid_logo.png for asteroid-logo.svg
  • Resize all svg to 800x800px due to recent discovery that svgs do not scale up properly Also this should add some future proofness for possible higher resolution watches to be supported.

Add 6 watchfaces

  • analog-nort
  • digital-shifted
  • analog-aviator
  • analog-words-80s
  • digital-numeral-unity
  • analog-scientific-v2

Copy link
Member

@jrtberlin jrtberlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a huge improvement.

But please split housekeeping and watchface additions into separate PRs next time.
This way, reviewers can:

  1. focus on one thing in the PR (adding a watchface vs. housekeeping). Maybe someone doesn't feel confident reviewing parts of the PR because the part is outside the field of expertise.
  2. it makes the PR smaller. People are more likely to take the time to review a small PR than something they have to dedicate a large amount of time to.

@jrtberlin jrtberlin merged commit 03ce2f7 into AsteroidOS:master Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants