request weather data and send them to the wirst #29
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| #include "openweathermapparser.h" | ||
|
|
||
| OpenWeatherMapParser::OpenWeatherMapParser(QObject *parent) : QObject(parent) | ||
| { | ||
| } | ||
|
|
||
| QList<short> OpenWeatherMapParser::getWeatherId(QJsonArray list) | ||
| { | ||
| QList<short> id; | ||
| QDateTime timestamp; | ||
|
|
||
| for(int i = 0; i < 5; i++) { | ||
|
There was a problem hiding this comment. I recommend using list.size() like in the other methods or you risk accessing undefined values. There was a problem hiding this comment. I think range-based loops should work on QJsonArray https://en.wikipedia.org/wiki/C%2B%2B11#Range-based_for_loop |
||
| QJsonObject dayInfo = list.takeAt(i).toObject(); | ||
| QJsonArray dayWeather = dayInfo.value("weather").toArray(); | ||
| QJsonObject firstEntry = dayWeather.takeAt(0).toObject(); | ||
|
There was a problem hiding this comment. QJsonArray has a |
||
| id << firstEntry.value("id").toInt(); | ||
| } | ||
|
|
||
| return id; | ||
| } | ||
|
|
||
| QList<short> OpenWeatherMapParser::getTempMin(QJsonArray list) | ||
| { | ||
| QList<short> tempMin; | ||
| QDateTime timestamp; | ||
| QJsonObject dayInfo = list.at(0).toObject(); | ||
| timestamp.setTime_t(dayInfo.value("dt").toInt()); | ||
| QString actDate = timestamp.toString("dd.MM.yyyy"); | ||
| QJsonObject dayMain = dayInfo.value("main").toObject(); | ||
| short int tmp = dayMain.value("temp_min").toDouble(); | ||
|
|
||
| for(int i = 1; i < list.size(); i++) { | ||
| dayInfo = list.at(i).toObject(); | ||
| timestamp.setTime_t(dayInfo.value("dt").toInt()); | ||
| dayMain = dayInfo.value("main").toObject(); | ||
| if(actDate == timestamp.toString("dd.MM.yyyy") && dayMain.value("temp_min").toDouble() < tmp) { | ||
|
There was a problem hiding this comment. a string comparison is always quite an expensive operation (and also a bit risky as a simple space or something is always a risk), it's usually the wrong way to approach a problem. What if you'd compare QDates instead https://doc.qt.io/qt-5/qdatetime.html#date ? |
||
| tmp = dayMain.value("temp_min").toDouble(); | ||
| } else if(actDate != timestamp.toString("dd.MM.yyyy")) { | ||
| tempMin << tmp; | ||
| actDate = timestamp.toString("dd.MM.yyyy"); | ||
| tmp = dayMain.value("temp_min").toDouble(); | ||
| } | ||
| } | ||
|
|
||
| return tempMin; | ||
| } | ||
|
|
||
| QList<short> OpenWeatherMapParser::getTempMax(QJsonArray list) | ||
| { | ||
| QList<short> tempMax; | ||
| QDateTime timestamp; | ||
| QJsonObject dayInfo = list.at(0).toObject(); | ||
| timestamp.setTime_t(dayInfo.value("dt").toInt()); | ||
| QString actDate = timestamp.toString("dd.MM.yyyy"); | ||
| QJsonObject dayMain = dayInfo.value("main").toObject(); | ||
| short int tmp = dayMain.value("temp_max").toDouble(); | ||
|
|
||
| for(int i = 1; i < list.size(); i++) { | ||
| dayInfo = list.at(i).toObject(); | ||
| timestamp.setTime_t(dayInfo.value("dt").toInt()); | ||
| dayMain = dayInfo.value("main").toObject(); | ||
| if(actDate == timestamp.toString("dd.MM.yyyy") && dayMain.value("temp_max").toDouble() > tmp) { | ||
| tmp = dayMain.value("temp_max").toDouble(); | ||
| } else if(actDate != timestamp.toString("dd.MM.yyyy")) { | ||
| tempMax << tmp; | ||
| actDate = timestamp.toString("dd.MM.yyyy"); | ||
| tmp = dayMain.value("temp_max").toDouble(); | ||
| } | ||
| } | ||
|
|
||
| return tempMax; | ||
| } | ||
|
|
||
| QString OpenWeatherMapParser::getCity(QJsonObject obj) | ||
| { | ||
| return obj.value("name").toString().trimmed(); | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| #ifndef OPENWEATHERMAPPARSER_H | ||
| #define OPENWEATHERMAPPARSER_H | ||
|
|
||
| #include <QObject> | ||
| #include <QJsonObject> | ||
| #include <QList> | ||
| #include <QJsonArray> | ||
| #include <QDateTime> | ||
|
|
||
| class OpenWeatherMapParser : public QObject | ||
|
There was a problem hiding this comment. Since the methods are all stateless you don't really need a class here (an object of type OpenWeatherMapParser doesn't carry any ownership/lifetime semantic) |
||
| { | ||
| Q_OBJECT | ||
|
|
||
| public: | ||
| OpenWeatherMapParser(QObject *parent = nullptr); | ||
|
|
||
| QList<short> getWeatherId(QJsonArray list); | ||
| QList<short> getTempMin(QJsonArray list); | ||
| QList<short> getTempMax(QJsonArray list); | ||
| QString getCity(const QJsonObject obj); | ||
| }; | ||
|
|
||
| #endif // OPENWEATHERMAPPARSER_H | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that this class does a lot, it would be helpful to name this into something more specific, maybe onOwmReplyFinished?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or maybe you could use a lambda and inline the slot in owmRequest. I think that's what the cool kids would do these days