Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notification sound effect #113

Merged
merged 2 commits into from
Feb 4, 2023
Merged

notification sound effect #113

merged 2 commits into from
Feb 4, 2023

Conversation

lepras
Copy link
Contributor

@lepras lepras commented Nov 25, 2022

in reference to this chat on matrix.

@MagneFire MagneFire self-requested a review December 21, 2022 22:00
Copy link
Member

@MagneFire MagneFire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR! And I'm sorry for taking this long to review it.

Please see the feedback on this PR.

When you remove the QuickSettings changes I think this PR should be ready to merge.
However, I think it would be better to eventually add these sound related events to the ngfd events: https://github.com/AsteroidOS/meta-asteroid/blob/master/recipes-nemomobile/ngfd/ngfd/events.d/alarm.ini#L1 and add some of the lines references here: https://github.com/sailfishos/ngfd/blob/master/data/events.d/clock.ini#L2.
We could even take advantage of profiles to alter the behaviour of alarm events: https://github.com/sailfishos/ngfd/blob/master/data/events.d/ringtone.ini#L4 this would remove the need to dynamically change the system volume.

qml/quicksettings/QuickSettings.qml Outdated Show resolved Hide resolved
@lepras
Copy link
Contributor Author

lepras commented Feb 3, 2023

re-synced to the upstream for merging.

@MagneFire MagneFire merged commit 1df95fe into AsteroidOS:master Feb 4, 2023
eLtMosen pushed a commit to eLtMosen/asteroid-launcher that referenced this pull request Apr 16, 2023
dodoradio pushed a commit to dodoradio/asteroid-launcher that referenced this pull request Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants