polkadot-v0.9.27 uplift #722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shunsukew
reviewed
Aug 5, 2022
| bool, | ||
| ) -> Result<Box<dyn ParachainConsensus<Block>>, sc_service::Error>, | ||
| { | ||
| if matches!(parachain_config.role, Role::Light) { |
Contributor
There was a problem hiding this comment.
Removing this means we got LightClient configuration part somewhere instead?
Contributor
Author
There was a problem hiding this comment.
I don't know where it is, all I've found is that it was removed from substrate.
To do the uplift, I removed the enum mention.
Contributor
There was a problem hiding this comment.
This shouldn't impact other types of nodes. We'd like to keep up with the LightClient development situation on Substrate side I think.
It's deprecated, no need for validation anymore.
paritytech/substrate#11865
shunsukew
approved these changes
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Uplift to
polkadot-v0.9.27.No major functionality changes in our code.
Check list