Skip to content

BREAKING CHANGE: Make class fields a special kind of property #2548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 14 commits into from
Closed

BREAKING CHANGE: Make class fields a special kind of property #2548

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
34317bb
prepare
dcodeIO Oct 26, 2022
5443e87
break it
dcodeIO Oct 29, 2022
4f67f94
transplant
dcodeIO Nov 4, 2022
632309e
lint
dcodeIO Nov 4, 2022
c53c4db
remove unused function
dcodeIO Nov 4, 2022
b8f7f9f
improve
dcodeIO Nov 4, 2022
87e4eab
unify bound functions and properties
dcodeIO Nov 4, 2022
6bd67fb
clarify
dcodeIO Nov 4, 2022
3d37394
clarify more
dcodeIO Nov 4, 2022
94536f9
Merge branch 'main' into property-fields
dcodeIO Nov 4, 2022
0eb99a7
set struct field names
dcodeIO Nov 5, 2022
ac6cd87
test, refactor
dcodeIO Nov 6, 2022
2ca10ec
generate static instanceof helpers
dcodeIO Nov 6, 2022
4911837
optimize, merge instanceof tests
dcodeIO Nov 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 0 additions & 61 deletions src/builtins.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@ import {
FunctionPrototype,
Global,
DecoratorFlags,
ClassPrototype,
Class,
PropertyPrototype
} from "./program";
Expand Down Expand Up @@ -10458,66 +10457,6 @@ export function compileRTTI(compiler: Compiler): void {
}
}

/** Compiles a class-specific instanceof helper, checking a ref against all concrete instances. */
export function compileClassInstanceOf(compiler: Compiler, prototype: ClassPrototype): void {
let module = compiler.module;
let sizeTypeRef = compiler.options.sizeTypeRef;
let instanceofInstance = assert(prototype.program.instanceofInstance);
compiler.compileFunction(instanceofInstance);

let stmts = new Array<ExpressionRef>();

// if (!ref) return false
stmts.push(
module.if(
module.unary(
sizeTypeRef == TypeRef.I64
? UnaryOp.EqzI64
: UnaryOp.EqzI32,
module.local_get(0, sizeTypeRef)
),
module.return(
module.i32(0)
)
)
);

// if (__instanceof(ref, ID[i])) return true
let instances = prototype.instances;
if (instances && instances.size > 0) {
// TODO: for (let instance of instances.values()) {
for (let _values = Map_values(instances), i = 0, k = _values.length; i < k; ++i) {
let instance = unchecked(_values[i]);
stmts.push(
module.if(
module.call(instanceofInstance.internalName, [
module.local_get(0, sizeTypeRef),
module.i32(instance.id)
], TypeRef.I32),
module.return(
module.i32(1)
)
)
);
}
}

// return false
stmts.push(
module.return(
module.i32(0)
)
);

module.addFunction(
`${prototype.internalName}~instanceof`,
sizeTypeRef,
TypeRef.I32,
null,
module.flatten(stmts)
);
}

// Helpers

let checkConstantType_expr: ExpressionRef = 0;
Expand Down
Loading