Skip to content

Remove local sharing logic #2540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Oct 23, 2022
Merged

Remove local sharing logic #2540

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
5c4e538
maintain local names in flows
dcodeIO Oct 20, 2022
5701d7e
simplify / compute non-parameter locals
dcodeIO Oct 21, 2022
3ded0fe
remove temp local logic
dcodeIO Oct 21, 2022
7e2f1ba
Merge branch 'main' into simplify-locals
dcodeIO Oct 21, 2022
c192bd5
refactor
dcodeIO Oct 21, 2022
3a0a2f3
increase default shadow stack size
dcodeIO Oct 21, 2022
a79ec5a
update fixtures
dcodeIO Oct 21, 2022
3a1838e
no more need for `var`
dcodeIO Oct 21, 2022
208403f
keep var in AST reserialization
dcodeIO Oct 21, 2022
4a2674c
half stack size
dcodeIO Oct 21, 2022
27dad05
simplify inlining
dcodeIO Oct 21, 2022
9fa421a
update cli help
dcodeIO Oct 21, 2022
b573d52
lint
dcodeIO Oct 21, 2022
aa23373
simplify
dcodeIO Oct 21, 2022
e59d754
be careful with local flags
dcodeIO Oct 22, 2022
52a51a1
sanity check
dcodeIO Oct 22, 2022
979e3aa
refactor
dcodeIO Oct 22, 2022
b78c1b9
fix
dcodeIO Oct 22, 2022
c32103d
clarify that Flow#parentFunction is targetFunction
dcodeIO Oct 22, 2022
85a5ed8
clarify that Flow#actualFunction is sourceFunction
dcodeIO Oct 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cli/options.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@
"description": [
"Overrides the stack size. Only relevant for incremental GC",
"or when using a custom runtime that requires stack space.",
"Defaults to 0 without and to 16384 with incremental GC."
"Defaults to 0 without and to 65536 with incremental GC."
],
"default": 0,
"type": "i"
Expand Down
10 changes: 5 additions & 5 deletions tests/compiler/NonNullable.debug.wat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@
(global $~lib/native/ASC_SHRINK_LEVEL i32 (i32.const 0))
(global $NonNullable/z (mut i32) (i32.const 224))
(global $~lib/memory/__data_end i32 (i32.const 300))
(global $~lib/memory/__stack_pointer (mut i32) (i32.const 16684))
(global $~lib/memory/__heap_base i32 (i32.const 16684))
(memory $0 1)
(global $~lib/memory/__stack_pointer (mut i32) (i32.const 65836))
(global $~lib/memory/__heap_base i32 (i32.const 65836))
(memory $0 2)
(data (i32.const 12) "\1c\00\00\00\00\00\00\00\00\00\00\00\01\00\00\00\06\00\00\00u\003\002\00\00\00\00\00\00\00")
(data (i32.const 44) ",\00\00\00\00\00\00\00\00\00\00\00\01\00\00\00\1c\00\00\00N\00o\00n\00N\00u\00l\00l\00a\00b\00l\00e\00.\00t\00s\00")
(data (i32.const 92) "\1c\00\00\00\00\00\00\00\00\00\00\00\01\00\00\00\0c\00\00\00S\00t\00r\00i\00n\00g\00")
Expand Down Expand Up @@ -221,8 +221,8 @@
global.get $~lib/memory/__data_end
i32.lt_s
if
i32.const 16704
i32.const 16752
i32.const 65856
i32.const 65904
i32.const 1
i32.const 1
call $~lib/builtins/abort
Expand Down
8 changes: 4 additions & 4 deletions tests/compiler/NonNullable.release.wat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
(type $i32_i32_i32_i32_=>_none (func_subtype (param i32 i32 i32 i32) func))
(type $none_=>_none (func_subtype func))
(import "env" "abort" (func $~lib/builtins/abort (param i32 i32 i32 i32)))
(global $~lib/memory/__stack_pointer (mut i32) (i32.const 17708))
(memory $0 1)
(global $~lib/memory/__stack_pointer (mut i32) (i32.const 66860))
(memory $0 2)
(data (i32.const 1036) "\1c")
(data (i32.const 1048) "\01\00\00\00\06\00\00\00u\003\002")
(data (i32.const 1068) ",")
Expand Down Expand Up @@ -146,8 +146,8 @@
i32.const 1324
i32.lt_s
if
i32.const 17728
i32.const 17776
i32.const 66880
i32.const 66928
i32.const 1
i32.const 1
call $~lib/builtins/abort
Expand Down
4 changes: 2 additions & 2 deletions tests/compiler/ReturnType.debug.wat
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
(module
(type $none_=>_none (func_subtype func))
(global $~lib/memory/__data_end i32 (i32.const 8))
(global $~lib/memory/__stack_pointer (mut i32) (i32.const 16392))
(global $~lib/memory/__heap_base i32 (i32.const 16392))
(global $~lib/memory/__stack_pointer (mut i32) (i32.const 65544))
(global $~lib/memory/__heap_base i32 (i32.const 65544))
(memory $0 0)
(table $0 1 1 funcref)
(elem $0 (i32.const 1))
Expand Down
6 changes: 3 additions & 3 deletions tests/compiler/abi.debug.wat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@
(global $abi/condition (mut i32) (i32.const 0))
(global $abi/y (mut i32) (i32.const 0))
(global $~lib/memory/__data_end i32 (i32.const 44))
(global $~lib/memory/__stack_pointer (mut i32) (i32.const 16428))
(global $~lib/memory/__heap_base i32 (i32.const 16428))
(memory $0 1)
(global $~lib/memory/__stack_pointer (mut i32) (i32.const 65580))
(global $~lib/memory/__heap_base i32 (i32.const 65580))
(memory $0 2)
(data (i32.const 12) "\1c\00\00\00\00\00\00\00\00\00\00\00\01\00\00\00\0c\00\00\00a\00b\00i\00.\00t\00s\00")
(table $0 1 1 funcref)
(elem $0 (i32.const 1))
Expand Down
2 changes: 1 addition & 1 deletion tests/compiler/abi.release.wat
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
(module
(type $none_=>_i32 (func_subtype (result i32) func))
(memory $0 1)
(memory $0 2)
(data (i32.const 1036) "\1c")
(data (i32.const 1048) "\01\00\00\00\0c\00\00\00a\00b\00i\00.\00t\00s")
(export "exported" (func $abi/exported))
Expand Down
4 changes: 2 additions & 2 deletions tests/compiler/asc-constants.debug.wat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@
(global $~lib/native/ASC_FEATURE_EXTENDED_CONST i32 (i32.const 0))
(global $~lib/native/ASC_FEATURE_STRINGREF i32 (i32.const 0))
(global $~lib/memory/__data_end i32 (i32.const 8))
(global $~lib/memory/__stack_pointer (mut i32) (i32.const 16392))
(global $~lib/memory/__heap_base i32 (i32.const 16392))
(global $~lib/memory/__stack_pointer (mut i32) (i32.const 65544))
(global $~lib/memory/__heap_base i32 (i32.const 65544))
(memory $0 0)
(table $0 1 1 funcref)
(elem $0 (i32.const 1))
Expand Down
10 changes: 5 additions & 5 deletions tests/compiler/assert-nonnull.debug.wat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@
(global $~lib/shared/runtime/Runtime.Incremental i32 (i32.const 2))
(global $~argumentsLength (mut i32) (i32.const 0))
(global $~lib/memory/__data_end i32 (i32.const 380))
(global $~lib/memory/__stack_pointer (mut i32) (i32.const 16764))
(global $~lib/memory/__heap_base i32 (i32.const 16764))
(memory $0 1)
(global $~lib/memory/__stack_pointer (mut i32) (i32.const 65916))
(global $~lib/memory/__heap_base i32 (i32.const 65916))
(memory $0 2)
(data (i32.const 12) "<\00\00\00\00\00\00\00\00\00\00\00\01\00\00\00\1e\00\00\00u\00n\00e\00x\00p\00e\00c\00t\00e\00d\00 \00n\00u\00l\00l\00\00\00\00\00\00\00\00\00\00\00\00\00\00\00")
(data (i32.const 76) "<\00\00\00\00\00\00\00\00\00\00\00\01\00\00\00\"\00\00\00a\00s\00s\00e\00r\00t\00-\00n\00o\00n\00n\00u\00l\00l\00.\00t\00s\00\00\00\00\00\00\00\00\00\00\00")
(data (i32.const 140) "<\00\00\00\00\00\00\00\00\00\00\00\01\00\00\00$\00\00\00I\00n\00d\00e\00x\00 \00o\00u\00t\00 \00o\00f\00 \00r\00a\00n\00g\00e\00\00\00\00\00\00\00\00\00")
Expand Down Expand Up @@ -84,8 +84,8 @@
global.get $~lib/memory/__data_end
i32.lt_s
if
i32.const 16784
i32.const 16832
i32.const 65936
i32.const 65984
i32.const 1
i32.const 1
call $~lib/builtins/abort
Expand Down
56 changes: 28 additions & 28 deletions tests/compiler/assert-nonnull.release.wat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
(type $none_=>_i32 (func_subtype (result i32) func))
(type $i32_i32_i32_i32_=>_none (func_subtype (param i32 i32 i32 i32) func))
(import "env" "abort" (func $~lib/builtins/abort (param i32 i32 i32 i32)))
(global $~lib/memory/__stack_pointer (mut i32) (i32.const 17788))
(memory $0 1)
(global $~lib/memory/__stack_pointer (mut i32) (i32.const 66940))
(memory $0 2)
(data (i32.const 1036) "<")
(data (i32.const 1048) "\01\00\00\00\1e\00\00\00u\00n\00e\00x\00p\00e\00c\00t\00e\00d\00 \00n\00u\00l\00l")
(data (i32.const 1100) "<")
Expand Down Expand Up @@ -39,8 +39,8 @@
i32.const 1404
i32.lt_s
if
i32.const 17808
i32.const 17856
i32.const 66960
i32.const 67008
i32.const 1
i32.const 1
call $~lib/builtins/abort
Expand Down Expand Up @@ -82,8 +82,8 @@
i32.const 1404
i32.lt_s
if
i32.const 17808
i32.const 17856
i32.const 66960
i32.const 67008
i32.const 1
i32.const 1
call $~lib/builtins/abort
Expand Down Expand Up @@ -117,8 +117,8 @@
i32.const 1404
i32.lt_s
if
i32.const 17808
i32.const 17856
i32.const 66960
i32.const 67008
i32.const 1
i32.const 1
call $~lib/builtins/abort
Expand Down Expand Up @@ -199,8 +199,8 @@
local.get $0
return
end
i32.const 17808
i32.const 17856
i32.const 66960
i32.const 67008
i32.const 1
i32.const 1
call $~lib/builtins/abort
Expand Down Expand Up @@ -299,8 +299,8 @@
local.get $0
return
end
i32.const 17808
i32.const 17856
i32.const 66960
i32.const 67008
i32.const 1
i32.const 1
call $~lib/builtins/abort
Expand Down Expand Up @@ -359,8 +359,8 @@
local.get $0
return
end
i32.const 17808
i32.const 17856
i32.const 66960
i32.const 67008
i32.const 1
i32.const 1
call $~lib/builtins/abort
Expand Down Expand Up @@ -430,8 +430,8 @@
local.get $0
return
end
i32.const 17808
i32.const 17856
i32.const 66960
i32.const 67008
i32.const 1
i32.const 1
call $~lib/builtins/abort
Expand Down Expand Up @@ -508,8 +508,8 @@
local.get $0
return
end
i32.const 17808
i32.const 17856
i32.const 66960
i32.const 67008
i32.const 1
i32.const 1
call $~lib/builtins/abort
Expand All @@ -531,8 +531,8 @@
i32.const 1404
i32.lt_s
if
i32.const 17808
i32.const 17856
i32.const 66960
i32.const 67008
i32.const 1
i32.const 1
call $~lib/builtins/abort
Expand Down Expand Up @@ -593,8 +593,8 @@
drop
unreachable
end
i32.const 17808
i32.const 17856
i32.const 66960
i32.const 67008
i32.const 1
i32.const 1
call $~lib/builtins/abort
Expand Down Expand Up @@ -632,8 +632,8 @@
drop
unreachable
end
i32.const 17808
i32.const 17856
i32.const 66960
i32.const 67008
i32.const 1
i32.const 1
call $~lib/builtins/abort
Expand All @@ -648,8 +648,8 @@
i32.const 1404
i32.lt_s
if
i32.const 17808
i32.const 17856
i32.const 66960
i32.const 67008
i32.const 1
i32.const 1
call $~lib/builtins/abort
Expand Down Expand Up @@ -698,8 +698,8 @@
drop
unreachable
end
i32.const 17808
i32.const 17856
i32.const 66960
i32.const 67008
i32.const 1
i32.const 1
call $~lib/builtins/abort
Expand Down
4 changes: 2 additions & 2 deletions tests/compiler/assert.debug.wat
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
(module
(type $none_=>_none (func_subtype func))
(global $~lib/memory/__data_end i32 (i32.const 8))
(global $~lib/memory/__stack_pointer (mut i32) (i32.const 16392))
(global $~lib/memory/__heap_base i32 (i32.const 16392))
(global $~lib/memory/__stack_pointer (mut i32) (i32.const 65544))
(global $~lib/memory/__heap_base i32 (i32.const 65544))
(memory $0 0)
(table $0 1 1 funcref)
(elem $0 (i32.const 1))
Expand Down
6 changes: 3 additions & 3 deletions tests/compiler/bigint-integration.debug.wat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@
(import "bigint-integration" "getExternalValue" (func $bigint-integration/getExternalValue (result i64)))
(global $bigint-integration/internalValue i64 (i64.const 9007199254740991))
(global $~lib/memory/__data_end i32 (i32.const 76))
(global $~lib/memory/__stack_pointer (mut i32) (i32.const 16460))
(global $~lib/memory/__heap_base i32 (i32.const 16460))
(global $~lib/memory/__stack_pointer (mut i32) (i32.const 65612))
(global $~lib/memory/__heap_base i32 (i32.const 65612))
(global $~started (mut i32) (i32.const 0))
(memory $0 1)
(memory $0 2)
(data (i32.const 12) "<\00\00\00\00\00\00\00\00\00\00\00\01\00\00\00*\00\00\00b\00i\00g\00i\00n\00t\00-\00i\00n\00t\00e\00g\00r\00a\00t\00i\00o\00n\00.\00t\00s\00\00\00")
(table $0 1 1 funcref)
(elem $0 (i32.const 1))
Expand Down
2 changes: 1 addition & 1 deletion tests/compiler/bigint-integration.release.wat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
(import "bigint-integration" "getExternalValue" (func $bigint-integration/getExternalValue (result i64)))
(global $bigint-integration/internalValue i64 (i64.const 9007199254740991))
(global $~started (mut i32) (i32.const 0))
(memory $0 1)
(memory $0 2)
(data (i32.const 1036) "<")
(data (i32.const 1048) "\01\00\00\00*\00\00\00b\00i\00g\00i\00n\00t\00-\00i\00n\00t\00e\00g\00r\00a\00t\00i\00o\00n\00.\00t\00s")
(export "internalValue" (global $bigint-integration/internalValue))
Expand Down
Loading