Skip to content

fix: #2206 indexing regexp #2263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dcodeIO merged 7 commits into from
Jul 23, 2022
Merged

fix: #2206 indexing regexp #2263

dcodeIO merged 7 commits into from
Jul 23, 2022

Conversation

@technohippy
Copy link
Member

@technohippy technohippy commented Apr 14, 2022 •
edited
Loading

⯈fix #2206
⯈fix #2207

  • I've read the contributing guidelines
  • I've added my name and email to the NOTICE file

romdotdog
romdotdog reviewed Apr 16, 2022
View reviewed changes
dcodeIO
dcodeIO reviewed Apr 23, 2022
View reviewed changes
@dcodeIO
Copy link
Member

dcodeIO commented Apr 23, 2022

While this introduces an error, it seems that what's missing here is resolving regexp literals to the RegExp type, similar to what is done for the numeric literals with I32 etc. That would then print a different error, but already prepare for an eventual implementation.

@technohippy
Copy link
Member Author

technohippy commented Apr 29, 2022

@dcodeIO I changed the pullreq. Is this what you thought?

1 similar comment
@technohippy
Copy link
Member Author

technohippy commented Apr 29, 2022

@dcodeIO I changed the pullreq. Is this what you thought?

@dcodeIO dcodeIO merged commit 3a5b51d into AssemblyScript:main Jul 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcodeIO dcodeIO dcodeIO left review comments

+1 more reviewer

@romdotdog romdotdog romdotdog left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

typeof a RegExp crashes the compiler Indexing a RegExp crashes the compiler

3 participants

@technohippy @dcodeIO @romdotdog