Skip to content

Conversation

@bnbarak
Copy link
Contributor

@bnbarak bnbarak commented Mar 28, 2021

  • I've read the contributing guidelines

What

Per #1708, I added global (magic?) variables for major, minor, and patch semantic versions. The version is coming from the the root package.json (either in the webpack step or in runtime).

ASC_VERSION_MAJOR;
ASC_VERSION_MINOR;
ASC_VERSION_PATCH;

Note

I usually use the npm package semver to parse semantic versioning. In this use case, I feel that this is simple enough that we should not add a dependency on semver. If we ever release beta/alpha/build number, then we should utilize semver.

Co-authored-by: Max Graey <[email protected]>
@bnbarak
Copy link
Contributor Author

bnbarak commented Mar 30, 2021

@MaxGraey Just wondering what is the merge process?

@dcodeIO dcodeIO merged commit ede042d into AssemblyScript:master Mar 30, 2021
@dcodeIO
Copy link
Member

dcodeIO commented Mar 30, 2021

Thank you! :)

@bnbarak bnbarak deleted the asc-version branch March 30, 2021 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants