Fill correct view region in crypto.getRandomValues #1659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one is security relevant in that the initial implementation of
crypto.getRandomValuesshipped in 0.18.0 does not fill the correct region of the typed array view ifbyteOffset>0. Luckily the API exists for only 6 days so far andbyteOffset>0is rare.Postmortem is that I initially designed the API for an
ArrayBufferargument, notUint8Array, and when I decided to switch toUint8Arrayfor more convenient usage of the API I apparently had an acute attack of stupidity. Reporting this myself after another acute attack of waaaiiit a minute...