issue-1617 Adding wrap definition. #1618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
That wraps it up. Should I squish the commits ? |
dcodeIO
reviewed
Jan 10, 2021
Member
dcodeIO
left a comment
dcodeIO
left a comment
There was a problem hiding this comment.
LGTM, but I think we should not generate the definition for interfaces, as these are merely types currently.
Co-authored-by: Daniel Wirtz <[email protected]>
Contributor
Author
|
@dcodeIO Got it. Maybe I should reference https://github.com/AssemblyScript/assemblyscript/blob/master/src/common.ts#L121 as well instead of hardcoding the |
dcodeIO
reviewed
Jan 18, 2021
dcodeIO
reviewed
Jan 18, 2021
Co-authored-by: Daniel Wirtz <[email protected]>
Member
|
Thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1617